Fixed Content-MD5 serialization and typing#16987
Merged
tasherif-msft merged 2 commits intoAzure:masterfrom Mar 1, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #15919.
Currently the way content-md5 is deserialized is the original bytearray. This is also what the customer is supposed to pass.
At the moment if the user passes content-md5 in
ContentSettings()and passes it toupload_blob()it would throw (pretty bad bug), since we are trying to serialize a passedstrwithout providing encoding type.This serialization is now removed and the customer can directly pass the content-md5 they get from calling
get_blob_peroperties()for example.