Skip to content

[SB] tests.yml - sample live test changes#16329

Merged
swathipil merged 6 commits intoAzure:masterfrom
swathipil:swathipil/sb/live-test-samples
Feb 12, 2021
Merged

[SB] tests.yml - sample live test changes#16329
swathipil merged 6 commits intoAzure:masterfrom
swathipil:swathipil/sb/live-test-samples

Conversation

@swathipil
Copy link
Copy Markdown
Member

No description provided.

@ghost ghost added the Service Bus label Jan 25, 2021
@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil force-pushed the swathipil/sb/live-test-samples branch from 59240d2 to 6b07a33 Compare January 29, 2021 18:33
@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link
Copy Markdown

check-enforcer bot commented Feb 2, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil force-pushed the swathipil/sb/live-test-samples branch from f21085f to aef5365 Compare February 3, 2021 19:25
@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - ci

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil force-pushed the swathipil/sb/live-test-samples branch from aef5365 to a70ea52 Compare February 5, 2021 18:16
@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil force-pushed the swathipil/sb/live-test-samples branch from a70ea52 to 1a82750 Compare February 9, 2021 20:54
@swathipil
Copy link
Copy Markdown
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil marked this pull request as ready for review February 10, 2021 16:03
@swathipil swathipil linked an issue Feb 10, 2021 that may be closed by this pull request
Comment on lines +30 to +46
"failure_and_recovery.py",
"mgmt_queue.py",
"mgmt_rule.py",
"mgmt_subscription.py",
"mgmt_topic.py",
"proxy.py",
"receive_deferred_message_queue.py",
"receive_iterator_queue.py",
"session_pool_receive.py",
"mgmt_queue_async.py",
"mgmt_rule_async.py",
"mgmt_subscription_async.py",
"mgmt_topic_async.py",
"proxy_async.py",
"receive_deferred_message_queue_async.py",
"receive_iterator_queue_async.py",
"session_pool_receive_async.py"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore these tests? please track all the samples being added here with issues

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,220 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dumb question: can you tell me what this file does?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question - It's an ARM template that's being used to create resources for samples, rather than setting the EnvVars in tests.yml. This is to align with other services, which are also moving towards using ARM templates, since they are easier to maintain than a growing list of EnvVars in the tests.yml file. Specifically, formrecognizer. Context here and issue here.

Copy link
Copy Markdown
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swathipil swathipil merged commit a53129e into Azure:master Feb 12, 2021
@swathipil swathipil deleted the swathipil/sb/live-test-samples branch February 12, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ServiceBus] Run samples in live test pipelines

3 participants