Handle missing certs model properties in 2016-10-01#13129
Merged
chlowell merged 1 commit intoAzure:masterfrom Aug 17, 2020
Merged
Handle missing certs model properties in 2016-10-01#13129chlowell merged 1 commit intoAzure:masterfrom
chlowell merged 1 commit intoAzure:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Key Vault API version 2016-10-01, two models are missing attributes added in version 7.0:
Code for wrapping generated models in hand-written ones doesn't handle this gracefully, raising
AttributeError. This PR makes the code tolerant of these missing attributes and adds a test to exercise it. The test is a medium-term thing. For the long run we need a better way to test multiple versions, something likepytest.mark.parametrizethat runs test cases with a client for each supported service version.There's at least one other issue preventing
CertificateClientfrom fully supporting 2016-10-01: #13122.