Skip to content

tox depends succeeds when common SDK dependencies are missing #12990

@chlowell

Description

@chlowell

The depends test installs a package and imports all its modules to identify missing dependencies. However, it begins by installing a number of common SDK dependencies. It therefore won't fail when the package under test doesn't declare a dependency on one or more of these. For example, azure-keyvault-secrets was missing a dependency on azure-common which wasn't discovered until manual verification of a release build.

This happens because depends depends on deps:

deps =
{[tools]deps}

which installs azure-sdk-tools:

[tools]
deps =
-r ../../../eng/test_tools.txt

../../../tools/azure-sdk-tools

which installs a few management packages:
'azure-mgmt-resource',
'azure-mgmt-storage',
'azure-mgmt-keyvault'

and all their transitive dependencies.

Metadata

Metadata

Assignees

Labels

ClientThis issue points to a problem in the data-plane of the library.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions