-
Notifications
You must be signed in to change notification settings - Fork 3.3k
tox depends succeeds when common SDK dependencies are missing #12990
Description
The depends test installs a package and imports all its modules to identify missing dependencies. However, it begins by installing a number of common SDK dependencies. It therefore won't fail when the package under test doesn't declare a dependency on one or more of these. For example, azure-keyvault-secrets was missing a dependency on azure-common which wasn't discovered until manual verification of a release build.
This happens because depends depends on deps:
azure-sdk-for-python/eng/tox/tox.ini
Lines 144 to 145 in cd568ca
| deps = | |
| {[tools]deps} |
which installs azure-sdk-tools:
azure-sdk-for-python/eng/tox/tox.ini
Lines 6 to 8 in cd568ca
| [tools] | |
| deps = | |
| -r ../../../eng/test_tools.txt |
azure-sdk-for-python/eng/test_tools.txt
Line 30 in cd568ca
| ../../../tools/azure-sdk-tools |
which installs a few management packages:
azure-sdk-for-python/tools/azure-sdk-tools/setup.py
Lines 22 to 24 in cd568ca
| 'azure-mgmt-resource', | |
| 'azure-mgmt-storage', | |
| 'azure-mgmt-keyvault' |
and all their transitive dependencies.