Conversation
…r better round tripping
|
API changes have been detected in API changes - public static OffsetDateTime parseDate(String dateString)
+ public static TimeAndFormat parseDate(String dateString) |
|
API changes have been detected in API changes + public class TimeAndFormat {
+ public TimeAndFormat(OffsetDateTime dateTime, DateTimeFormatter formatter)
+ public OffsetDateTime getDateTime()
+ public DateTimeFormatter getFormatter()
+ }
- public static OffsetDateTime parseDate(String dateString)
+ public static TimeAndFormat parseDate(String dateString)
+ public static TimeAndFormat parseDateAndFormat(String dateString) |
| * @throws IllegalArgumentException If {@code dateString} doesn't match an ISO8601 pattern | ||
| */ | ||
| public static OffsetDateTime parseDate(String dateString) { | ||
| public static TimeAndFormat parseDate(String dateString) { |
There was a problem hiding this comment.
nit: mark parseDate as deprecated instead of changing the API
| * @return the corresponding <code>Date</code> object | ||
| * @throws IllegalArgumentException If {@code dateString} doesn't match an ISO8601 pattern | ||
| */ | ||
| public static TimeAndFormat parseDateAndFormat(String dateString) { |
There was a problem hiding this comment.
Given that azure-storage-common exposes it's implementation packages to the other azure-storage libraries we should think about moving this into implementation in case we need to do API changes to it in the future.
| * or in a connection string, we have to preserve the formatting, especially the precision, so the signature still | ||
| * matches. | ||
| */ | ||
| public class TimeAndFormat { |
There was a problem hiding this comment.
Same comment about the new utility method, unless we're expecting to return this in public APIs somewhere. Also, let's make it final
|
API changes have been detected in API changes + public class TimeAndFormat {
+ public TimeAndFormat(OffsetDateTime dateTime, DateTimeFormatter formatter)
+ public OffsetDateTime getDateTime()
+ public DateTimeFormatter getFormatter()
+ }
+ public static TimeAndFormat parseDateAndFormat(String dateString) |
|
API changes have been detected in API changes + public final class TimeAndFormat {
+ public TimeAndFormat(OffsetDateTime dateTime, DateTimeFormatter formatter)
+ public OffsetDateTime getDateTime()
+ public DateTimeFormatter getFormatter()
+ }
- public static OffsetDateTime parseDate(String dateString)
+ @Deprecated public static OffsetDateTime parseDate(String dateString) |
| * or in a connection string, we have to preserve the formatting, especially the precision, so the signature still | ||
| * matches. | ||
| */ | ||
| public final class TimeAndFormat { |
There was a problem hiding this comment.
Given this class isn't exposed in any public APIs does it itself need to be exposed as a public API?
|
API changes have been detected in API changes - public static OffsetDateTime parseDate(String dateString)
+ @Deprecated public static OffsetDateTime parseDate(String dateString) |
Resolves #22042