Skip to content

[BUG] Revisit ReactorNettyHttpResponse::close() #10467

@anuchandy

Description

@anuchandy

It looks like there are cases where when ReactorNettyHttpResponse::close() is called the connection is in the disposed state but the underlying body is not drained, which can result in leak warnings from netty.

Need to followup with the reactor-netty team to understand the behavior of connection disposal.

This is not impacting the majority of the cases since almost all cases either we subscribe to the body in RestPoxy or by the user when downloading as raw ByteBuf. One case in key-vault revealed this issue where it was not disposing the body inside the policy and was expecting close() to do it

Metadata

Metadata

Labels

Azure.Coreazure-coreClientThis issue points to a problem in the data-plane of the library.HttpClientpillar-reliabilityThe issue is related to reliability, one of our core engineering pillars. (includes stress testing)

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions