Skip to content

Commit 2921649

Browse files
ibrandesibrandes
authored
cherrypicking just storage linting changes (#47049)
1 parent 010e556 commit 2921649

32 files changed

Lines changed: 56 additions & 586 deletions

File tree

‎sdk/storage/azure-storage-blob-batch/checkstyle-suppressions.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->
44

55
<suppressions>
6-
<suppress files="com.azure.storage.blob.batch.BlobBatchOperationResponse.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
6+
<suppress files="com.azure.storage.blob.batch.BlobBatchOperationResponse.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
77
</suppressions>

‎sdk/storage/azure-storage-blob-batch/pom.xml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,7 @@
4545
</javaModulesSurefireArgLine>
4646
<parallelizeLiveTests>concurrent</parallelizeLiveTests>
4747

48-
<checkstyle.suppressionsLocation>checkstyle-suppressions.xml</checkstyle.suppressionsLocation>
49-
5048
<spotbugs.skip>false</spotbugs.skip>
51-
<spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
5249
</properties>
5350

5451
<dependencies>

‎sdk/storage/azure-storage-blob-batch/spotbugs-exclude.xml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,4 @@
22

33
<FindBugsFilter xmlns="https://github.com/spotbugs/filter/3.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:schemaLocation="https://github.com/spotbugs/filter/3.0.0 https://raw.githubusercontent.com/spotbugs/spotbugs/3.1.0/spotbugs/etc/findbugsfilter.xsd">
5-
<Match>
6-
<Bug pattern="SIC_INNER_SHOULD_BE_STATIC_ANON" />
7-
<Class name="com.azure.storage.blob.batch.BlobBatchAsyncClient" />
8-
</Match>
95
</FindBugsFilter>

‎sdk/storage/azure-storage-blob-changefeed/checkstyle-suppressions.xml‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,4 @@
33
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->
44

55
<suppressions>
6-
<suppress files="com.azure.storage.blob.changefeed.implementation.models.ChangefeedCursor.java" checks="JavadocMethodCheck" />
7-
<suppress files="com.azure.storage.blob.changefeed.implementation.models.SegmentCursor.java" checks="JavadocMethodCheck" />
8-
<suppress files="com.azure.storage.blob.changefeed.implementation.models.ShardCursor.java" checks="JavadocMethodCheck" />
9-
<suppress files="com.azure.storage.blob.changefeed.implementation.util.DownloadUtils.java" checks="JavadocMethodCheck" />
10-
<suppress files="com.azure.storage.blob.changefeed.implementation.util.TimeUtils.java" checks="JavadocMethodCheck" />
11-
<suppress files="com.azure.storage.blob.changefeed.implementation.models.InternalBlobChangefeedEvent.java" checks="MissingJavadocMethodCheck" />
12-
<suppress files="com.azure.storage.blob.changefeed.implementation.util.DownloadUtils.java" checks="MissingJavadocMethodCheck" />
13-
<suppress files="com.azure.storage.blob.changefeed.implementation.util.DownloadUtils.java" checks="MissingJavadocTypeCheck" />
14-
<suppress files="com.azure.storage.blob.changefeed.implementation.util.TimeUtils.java" checks="MissingJavadocTypeCheck" />
156
</suppressions>

‎sdk/storage/azure-storage-blob-changefeed/pom.xml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,7 @@
5252
</javaModulesSurefireArgLine>
5353
<parallelizeLiveTests>concurrent</parallelizeLiveTests>
5454

55-
<checkstyle.suppressionsLocation>checkstyle-suppressions.xml</checkstyle.suppressionsLocation>
56-
5755
<spotbugs.skip>false</spotbugs.skip>
58-
<spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
5956
</properties>
6057

6158
<dependencies>

‎sdk/storage/azure-storage-blob-changefeed/spotbugs-exclude.xml‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,4 @@
66
<Bug pattern="CT_CONSTRUCTOR_THROW" />
77
<Class name="com.azure.storage.blob.changefeed.Changefeed" />
88
</Match>
9-
<Match>
10-
<Bug pattern="EI_EXPOSE_REP" />
11-
<Or>
12-
<Class name="com.azure.storage.blob.changefeed.BlobChangefeedPagedResponse" />
13-
<Class name="com.azure.storage.blob.changefeed.implementation.models.SegmentCursor" />
14-
</Or>
15-
</Match>
16-
<Match>
17-
<Bug pattern="EI_EXPOSE_REP2" />
18-
<Class name="com.azure.storage.blob.changefeed.implementation.models.SegmentCursor" />
19-
</Match>
209
</FindBugsFilter>

‎sdk/storage/azure-storage-blob-cryptography/checkstyle-suppressions.xml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->
44

55
<suppressions>
6-
<suppress files="com.azure.storage.blob.specialized.cryptography.EncryptedBlobAsyncClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" />
7-
<suppress files="com.azure.storage.blob.specialized.cryptography.EncryptedBlobClient.java" checks="com.azure.tools.checkstyle.checks.ServiceClientCheck" />
6+
<suppress files="com.azure.storage.blob.specialized.cryptography.EncryptedBlobAsyncClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClientCheck" />
7+
<suppress files="com.azure.storage.blob.specialized.cryptography.EncryptedBlobClient.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ServiceClientCheck" />
88
</suppressions>

‎sdk/storage/azure-storage-blob-cryptography/pom.xml‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@
4646
</javaModulesSurefireArgLine>
4747
<parallelizeLiveTests>concurrent</parallelizeLiveTests>
4848

49-
<checkstyle.suppressionsLocation>checkstyle-suppressions.xml</checkstyle.suppressionsLocation>
50-
5149
<spotbugs.skip>false</spotbugs.skip>
52-
<spotbugs.excludeFilterFile>spotbugs-exclude.xml</spotbugs.excludeFilterFile>
5350
</properties>
5451

5552
<dependencies>

‎sdk/storage/azure-storage-blob-cryptography/spotbugs-exclude.xml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,4 @@
66
<Bug pattern="CT_CONSTRUCTOR_THROW" />
77
<Class name="com.azure.storage.blob.specialized.cryptography.EncryptorV1" />
88
</Match>
9-
<Match>
10-
<Bug pattern="EI_EXPOSE_REP2" />
11-
<Class name="com.azure.storage.blob.specialized.cryptography.EncryptedBlobClientBuilder" />
12-
</Match>
139
</FindBugsFilter>

‎sdk/storage/azure-storage-blob-nio/checkstyle-suppressions.xml‎

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@
33
<!-- This file is generated by the /eng/scripts/linting_suppression_generator.py script. -->
44

55
<suppressions>
6-
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="com.azure.tools.checkstyle.checks.GoodLoggingCheck" />
7-
<suppress files="com.azure.storage.blob.nio.AzureBasicFileAttributeView.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
8-
<suppress files="com.azure.storage.blob.nio.AzureBlobFileAttributeView.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
9-
<suppress files="com.azure.storage.blob.nio.AzureDirectoryStream.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
10-
<suppress files="com.azure.storage.blob.nio.AzureFileStore.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
11-
<suppress files="com.azure.storage.blob.nio.AzureFileSystem.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
12-
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
13-
<suppress files="com.azure.storage.blob.nio.AzurePath.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
14-
<suppress files="com.azure.storage.blob.nio.AzureResource.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
15-
<suppress files="com.azure.storage.blob.nio.AzureSeekableByteChannel.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
16-
<suppress files="com.azure.storage.blob.nio.NioBlobInputStream.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
17-
<suppress files="com.azure.storage.blob.nio.NioBlobOutputStream.java" checks="com.azure.tools.checkstyle.checks.ThrowFromClientLoggerCheck" />
18-
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="com.azure.tools.checkstyle.checks.UseCaughtExceptionCauseCheck" />
6+
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="io.clientcore.linting.extensions.checkstyle.checks.GoodLoggingCheck" />
7+
<suppress files="com.azure.storage.blob.nio.AzureBasicFileAttributeView.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
8+
<suppress files="com.azure.storage.blob.nio.AzureBlobFileAttributeView.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
9+
<suppress files="com.azure.storage.blob.nio.AzureDirectoryStream.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
10+
<suppress files="com.azure.storage.blob.nio.AzureFileStore.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
11+
<suppress files="com.azure.storage.blob.nio.AzureFileSystem.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
12+
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
13+
<suppress files="com.azure.storage.blob.nio.AzurePath.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
14+
<suppress files="com.azure.storage.blob.nio.AzureResource.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
15+
<suppress files="com.azure.storage.blob.nio.AzureSeekableByteChannel.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
16+
<suppress files="com.azure.storage.blob.nio.NioBlobInputStream.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
17+
<suppress files="com.azure.storage.blob.nio.NioBlobOutputStream.java" checks="io.clientcore.linting.extensions.checkstyle.checks.ThrowFromClientLoggerCheck" />
18+
<suppress files="com.azure.storage.blob.nio.AzureFileSystemProvider.java" checks="io.clientcore.linting.extensions.checkstyle.checks.UseCaughtExceptionCauseCheck" />
1919
</suppressions>

0 commit comments

Comments
 (0)