[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview#8996
[Hub Generated] Review request for Microsoft.KeyVault to add version preview/2020-04-01-preview#8996fengzhou-msft merged 17 commits intoAzure:masterfrom riteshchitlangia1:dev-keyvault-Microsoft.KeyVault-2020-04-01-preview
Conversation
|
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-js - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-python - Release
|
azure-sdk-for-go - Release
|
azure-sdk-for-net - Release
|
|
Can one of the admins verify this patch? |
heaths
left a comment
There was a problem hiding this comment.
Why are there two PRs for adding a new version? This will likely cause conflicts when trying to merge, and is certainly causing some confusion. 😉
Please use this PR for review. Other PR will be abandoned. |
|
I left a comment on the other one asking for a semantic diff.
|
This is giving same validation error and not generating semantic diff correctly. I have posted to Open API Support team about this too. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
I checked but could not find any differences except CreateMode string which is an optional parameter, so have not defined it in the request. |
chiragg4u
left a comment
There was a problem hiding this comment.
Approved. Re previous comments looks like I was looking at an older model.
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-sdk-for-python-track2 - Release
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Swagger pipeline can not start as the pull request has merge conflicts. |
|
Pull request contains merge conflicts. |
[Staging] Swagger Validation Report
️✔️ |
|
No commit pushedDate could be found for PR 8996 in repo Azure/azure-rest-api-specs |
|
/azp run automation - sdk |
|
Azure Pipelines successfully started running 1 pipeline(s). |
azure-resource-manager-schemas - Release
|
If you are a MSFT employee you can view your work branch via this link.
Contribution checklist: