Skip to content

Updated QnAMaker Runtime API headers descriptions#6559

Merged
yaohaizh merged 7 commits intoAzure:masterfrom
rokulka:master
Jul 25, 2019
Merged

Updated QnAMaker Runtime API headers descriptions#6559
yaohaizh merged 7 commits intoAzure:masterfrom
rokulka:master

Conversation

@rokulka
Copy link
Copy Markdown
Contributor

@rokulka rokulka commented Jul 5, 2019

No description provided.

@openapi-sdkautomation
Copy link
Copy Markdown

openapi-sdkautomation Bot commented Jul 5, 2019 •
edited
Loading

SDK Automation [Logs] (Generated from 70d1ba4, Iteration 4)

Failed Python: Azure/azure-sdk-for-python [Logs]
  • No packages generated.
Failed Java: Azure/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: Azure/azure-sdk-for-go [Logs]
  • No packages generated.
Failed JavaScript: Azure/azure-sdk-for-js [Logs]
  • No packages generated.
Warning Ruby: Azure/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@azuresdkci azuresdkci requested a review from yaohaizh July 5, 2019 08:49
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#5627

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 5, 2019 •
edited
Loading

Automation for azure-sdk-for-java

Encountered a Subprocess error: (azure-sdk-for-java)

Command: ['/usr/local/bin/autorest', '/tmp/tmpctvpjxew/rest/specification/cognitiveservices/data-plane/QnAMaker/readme.md', '--azure-libraries-for-java-folder=/tmp/tmpctvpjxew/sdk', '--java', '--multiapi', '--use=@microsoft.azure/autorest.java@2.1.85', '--verbose']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4283; node: v10.15.3]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@microsoft.azure_autorest-core@2.0.4383/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4383)
   Loading AutoRest extension '@microsoft.azure/autorest.java' (2.1.85->2.1.85)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.38->2.3.38)
FATAL: swagger-document/compose - FAILED
FATAL: Error: The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).
Process() cancelled due to exception : The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).
  Error: The 'title' across provided OpenAPI definitions has to match. Found: 'QnAMaker Client', 'QnAMaker Runtime Client'. Please adjust or provide an override (--title=...).

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Jul 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Jul 5, 2019

Can one of the admins verify this patch?

@yaohaizh
Copy link
Copy Markdown
Contributor

yaohaizh commented Jul 8, 2019

@yangyuang, @DavidLiCIG Please help review this PR, thanks.

ghost
ghost reviewed Jul 8, 2019
View reviewed changes
Comment thread specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMakerRuntime.json Outdated
ghost
ghost reviewed Jul 8, 2019
View reviewed changes
Comment thread specification/cognitiveservices/data-plane/QnAMaker/stable/v4.0/QnAMakerRuntime.json Outdated
@yangyuan
Copy link
Copy Markdown
Member

yangyuan commented Jul 15, 2019

Hi @rokulka and @bingisbestest

Can you explain why we have two swaggers with two titles and under two release tags?

If we want to have 1 package with 2 clients, we should include both in the same release tag.
If we want to have 2 packages and 1 client in each package, we need some structure changes in here.

@ghost
Copy link
Copy Markdown

ghost commented Jul 16, 2019 •
edited by ghost
Loading

If we want to have 1 package with 2 clients, we should include both in the same release tag.

This is exactly the goal. @rokulka please fix the release tag as well.
Thanks @yangyuang for pointer

@yaohaizh yaohaizh added the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 16, 2019
@rokulka
Copy link
Copy Markdown
Contributor Author

rokulka commented Jul 16, 2019

Hi @rokulka and @bingisbestest

Can you explain why we have two swaggers with two titles and under two release tags?

If we want to have 1 package with 2 clients, we should include both in the same release tag.
If we want to have 2 packages and 1 client in each package, we need some structure changes in here.

@yangyuan We need different Titles, as we need different classes for our SDK. Could you suggest a way
for that? I will ping you over Teams for a brief sync up.

@yaohaizh yaohaizh removed the APIStewardshipBoard-ReviewRequested This should be reviewed by the Azure API Stewardship team in partnership with the service team. label Jul 22, 2019
@AutorestCI AutorestCI mentioned this pull request Jul 23, 2019
Merged
@ghost
Copy link
Copy Markdown

ghost commented Jul 23, 2019

@yangyuan Please take a look.

yangyuan
yangyuan requested changes Jul 23, 2019
View reviewed changes
Comment thread specification/cognitiveservices/data-plane/QnAMaker/readme.md
@rokulka
Copy link
Copy Markdown
Contributor Author

rokulka commented Jul 25, 2019

@yaohaizh Can you please approve and merge the request.

@yaohaizh yaohaizh merged commit ad67077 into Azure:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yangyuan yangyuan yangyuan approved these changes

@DavidLiCIG DavidLiCIG Awaiting requested review from DavidLiCIG

+2 more reviewers

@yaohaizh yaohaizh yaohaizh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yaohaizh yaohaizh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rokulka @AutorestCI @azuresdkci @yaohaizh @yangyuan