Skip to content

Fix typo in Compute ImageDiskReference::id description#3966

Merged
anuchandy merged 4 commits intoAzure:masterfrom
wilsonge:patch-1
Sep 26, 2018
Merged

Fix typo in Compute ImageDiskReference::id description#3966
anuchandy merged 4 commits intoAzure:masterfrom
wilsonge:patch-1

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Sep 20, 2018 •
edited
Loading

Note it exists in the historical versions of the spec too. But I'm just fixing the latest one as that's the one used in the public docs...

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkci
Copy link
Copy Markdown
Contributor

azuresdkci commented Sep 20, 2018

Can one of the admins verify this patch?

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-js

Nothing to generate for azure-sdk-for-js

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#3701

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#3437

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-ruby

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-ruby#1577

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-java

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-java#2165

@AutorestCI AutorestCI mentioned this pull request Sep 20, 2018
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 20, 2018 •
edited
Loading

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#2815

@anuchandy anuchandy changed the title Fix typo Fix typo in Compute ImageDiskReference::id description Sep 20, 2018
@anuchandy
Copy link
Copy Markdown
Member

anuchandy commented Sep 20, 2018

@wilsonge thanks for the contribution.

@hyonholee while running CI for this PR, we came to know that the default package causes codegen to fail. See more info here #3968, please address the issue ASAP.

@hyonholee
Copy link
Copy Markdown
Contributor

hyonholee commented Sep 21, 2018

Please fix the following files too:

preview\2016-04-30-preview\disk.json
stable\2017-03-30\disk.json
stable\2018-04-01\disk.json

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Sep 21, 2018

Fixed in the other files mentioned

This was referenced Sep 22, 2018
Merged
Merged
Merged
@anuchandy anuchandy merged commit 6a92e04 into Azure:master Sep 26, 2018
This was referenced Sep 26, 2018
Merged
Merged
@wilsonge wilsonge deleted the patch-1 branch September 26, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anuchandy anuchandy anuchandy approved these changes

Assignees

@anuchandy anuchandy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wilsonge @azuresdkci @AutorestCI @anuchandy @hyonholee