Local september branch merge to master by MikhailTryakhov · Pull Request #3862 · Azure/azure-rest-api-specs

MikhailTryakhov · 2018-09-11T03:51:21Z

solved conflicts from #3861

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

* Swagger Coverage/Completeness- for operation CheckNameAvailability (Azure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Update dns management Node.js version number to 3.0.0 (Azure#3675) * Update batchai Node.js package version to 2.0.2 (Azure#3664) * Update nofiticationhubs management Node.js package version to 2.0.0 (Azure#3665) * WebApps - Add BackupName to backup API models (Azure#3560) * WebApps - Add BackupName to replace non-ARM-compliant Name property on Backup API models * Revert breaking change to BackupItem. BackupItemName property will be fine in place of BackupName for now. * Update authorization management Node.js package version to 5.0.1 (Azure#3676) * Update storagesync management Node.js package version to 1.0.0 (Azure#3677) * add checknameavailability (Azure#3608) * add checknameavailability * move checkname parameter to definition section * fix brackets * fix parameter name in checknameavailability exanple * update code owners for PowerBIDedicated * New Batch data plane API version 2018-08-01.7.0 (Azure#3657) * Add new batch version 2018-08-01.7.0 * Update the new API * Fix up output from OAD, it does not output valid JSON * update OAV (Azure#3678) * Update storage management Node.js package version to 5.2.0 (Azure#3679) * Update compute.json and disk.json for some issues and add zone and rolling upgrade. (Azure#3642) * Breaking change tool correctly handles multiple files with same name * Fix to breaking changes table generation * Trusted Root certificate (Azure#3668)

* Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples

* Added address prefixes to subnet * Added example of multiple address prefixes.

* Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change

…nalPublic (Azure#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes Azure#3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example

* Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation

* Swagger Coverage/Completeness- for operation CheckNameAvailability (Azure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme

* NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages

* Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources

* Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments.

* Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure

* Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions.

* add network profile swagger and examples * add x-ms-client-flatten property as per feedback * appease travis by fixing model + examples

…zure#3840) * add service association links for virtual network * add ipconfig profiles on subnet * fixed example issue * Review for tabfix and properties fromat rename

* vtapswaggerupdate * Adding readonly property

* Brooklyn Ignite Swagger changes * Add missing example file changes * Add virtual hub route table * Fix travis build error * VPN profile bugfix * Fix casing for NRP automapping * Fix parsing errors * remove BgpSettings from P2SVpnGateway object * Added AddressPrefixes on Subnet properties (Azure#3714) * Added address prefixes to subnet * Added example of multiple address prefixes. * Python Network conf 2018-08-01 * Changes to include required properties for outbound rule (Azure#3728) * Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change * Fix Python 2018-08 conf * Fix swagger contract errors with NRP * Fix network swagger * Fix virtualHub Properties for SDK and PS JSON serializer compliance * Fix bugs * Changing Cortex swagger to match NRP * Bug fixes * bugFix3 * Bug fix * Use only PublicIpAddress in Azure Firewall, not both Public and InternalPublic (Azure#3743) * Do not confuse users with both InternalPublicIp and PublicIp for the same thing * Update AzureFirewall PUT example * This closes Azure#3474 * Use the correct name for publicIPAddress in AzureFirewall PUT example * Azure Firewall FQDN Tag top level resource (Azure#3744) * Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation * Vtapfinal (Azure#3684) * Swagger Coverage/Completeness- for operation CheckNameAvailability (Azure#3663) * Update service.json * CheckNameAvailability * FIxed Parameter name fixed couple of parameters name * Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples * vtap update * VTAP changes * VTAP changes * Adding examples for VTAP resource * Update changes for Examples * Further fixes to examples * Add exception for vtap's RequiredPropertiesMissingInResourceModel in readme * Azure Firewall NAT Rule Collection (Azure#3745) * NAT Rule Collections for Azure Firewall * Update examples to include the new NAT Rule Collection * Shorten the NAT RC Properties name and mark etag read-only * Add NAT Rule Collection to Azure Firewall properties * Fix all <<a Azure>> in helper messages * Do not allow ICMP as Network protocol (Azure#3742) * Adding linkedResourceType and hostedWorkloads to nic (Azure#3780) * Adding support for interface endpoints (Azure#3783) * Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources * Added Trusted root certificate changes to new API version (Azure#3731) * Add ExpressRoute gateway resource (Azure#3776) * Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments. * Adding support for delegations on a subnet (Azure#3805) * Adding subnet delegation property on VNET * Updating subnet/vnet create & get examples to reflect delegation * Adding support for GetAvailableDelegations operation * Fixing properties in Swagger & updating examples to reflect fixes * Add availableDelegation as a subResource * Remove type from examples * Further updates to delegation PR * Additional changes to structure * Correct issues for SDK generation (Azure#3818) * Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions. * Rename TargetUrls to TargetFqdns (Azure#3739) * Fix travis errors in examples * Fixed error examples for P2S cortex resources * Fix swagger * Fix Semantic validation error * network swagger fix * Fix travis * Fix travis errors * Revert version change * Dummy changes for CI restart

* Relocated readOnly property * Readded provisioning state to interfaceEndpoint.json * Updated networkInterface.json * Updated serviceEndpointPolicy.json * Update virtualNetworkTap.json * Fix semantic issue * Multiple changes * More example fixes * Dummy commit * Fixed duplicate

…e#3860)

# Conflicts: # package.json # specification/authorization/resource-manager/readme.nodejs.md # specification/batch/data-plane/Microsoft.Batch/stable/2018-08-01.7.0/BatchService.json # specification/batch/data-plane/readme.md # specification/batch/data-plane/readme.nodejs.md # specification/batchai/resource-manager/readme.nodejs.md # specification/dns/resource-manager/readme.nodejs.md # specification/network/resource-manager/readme.md # specification/notificationhubs/resource-manager/readme.nodejs.md # specification/storage/resource-manager/readme.nodejs.md # specification/storagesync/resource-manager/readme.nodejs.md

AutorestCI · 2018-09-11T04:15:03Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3246

This reverts commit 3ff4b52.

azuresdkci · 2018-09-11T04:34:32Z

Can one of the admins verify this patch?

AutorestCI · 2018-09-11T09:35:39Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

MikhailTryakhov · 2018-09-11T16:06:59Z

@dsgouda @lmazuel updated PR

dsgouda

LGTM will merge on CIs passing

AutorestCI · 2018-09-11T19:15:02Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2018-09-11T19:33:16Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2018-09-11T19:57:30Z

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

akshaysngupta and others added 29 commits August 20, 2018 10:21

Trusted Root certificate (Azure#3668)

3ff4b52

Updated Microsoft.Network version to 2018-08-01 (Azure#3672)

0cb6322

* Adds base for updating Microsoft.Network from version stable/2018-07-01 to version 2018-08-01 * Updates readme * Updates API version in new specs and examples

Added AddressPrefixes on Subnet properties (Azure#3714)

b45ebe6

* Added address prefixes to subnet * Added example of multiple address prefixes.

Python Network conf 2018-08-01

34561ef

Changes to include required properties for outbound rule (Azure#3728)

6237750

* Mark outbound rule properties as required * Update outbound rule with required properties * Removing old change

Fix Python 2018-08 conf

6fdd0b9

Azure Firewall FQDN Tag top level resource (Azure#3744)

46f2423

* Azure Firewall FQDN Tag top level resource * Name FqdnTags property in AzureFirewallApplicationRule properly * Empty commit to trigger new validation

Do not allow ICMP as Network protocol (Azure#3742)

45af62f

Adding linkedResourceType and hostedWorkloads to nic (Azure#3780)

17d1ddf

Adding support for interface endpoints (Azure#3783)

da8dc7c

* Creating Interface Endpoint definition * Adding references to interface endpoints in existing resources

Added Trusted root certificate changes to new API version (Azure#3731)

3b1d5ec

Add ExpressRoute gateway resource (Azure#3776)

57fc3df

* Initial version * Refactor connections. * Update API version * Add enum values. * Addressed all comments.

Correct issues for SDK generation (Azure#3818)

cbb2ecf

* Remove x-ms-client-flatten attribute as that results in wrong descriptiosn during generation of the SDKs. * Missing descriptions.

Rename TargetUrls to TargetFqdns (Azure#3739)

a3b4803

Add Network Profile swagger and examples (Azure#3806)

cc47342

* add network profile swagger and examples * add x-ms-client-flatten property as per feedback * appease travis by fixing model + examples

vtapswaggerupdate (Azure#3837)

e9e8c83

Add Service Association Link and IP Configuration Profiles on Subnet (A…

c60ac4a

…zure#3840) * add service association links for virtual network * add ipconfig profiles on subnet * fixed example issue * Review for tabfix and properties fromat rename

Vtap swagger update and made the property as readonly (Azure#3845)

2bcec07

* vtapswaggerupdate * Adding readonly property

Updated AppGW Autoscale Configuration (Azure#3838)

0179f86

VPN gateway new API for Reset VPN client PSK (Azure#3800)

c34505c

changes to swagger in interface endpoints and subnet delegation (Azur…

e6195d0

…e#3860)

MikhailTryakhov requested a review from dsgouda September 11, 2018 03:51

AutorestCI mentioned this pull request Sep 11, 2018

[AutoPR network/resource-manager] Local september branch merge to master Azure/azure-sdk-for-python#3316

Merged

MikhailTryakhov added 2 commits September 10, 2018 21:24

Revert "Trusted Root certificate (Azure#3668)"

7ecae9c

This reverts commit 3ff4b52.

fixed api version in azure firewall example

ec5a468

azuresdkci assigned jianghaolu Sep 11, 2018

azuresdkci requested a review from jianghaolu September 11, 2018 04:35

Nilambari and others added 2 commits September 11, 2018 08:33

Review comments incorporation (Azure#3859)

f20941e

Merge branch 'Network-September-Release' into local-september-branch

e4e4d8a

dsgouda approved these changes Sep 11, 2018

View reviewed changes

dsgouda merged commit 42006c5 into Azure:master Sep 11, 2018

AutorestCI mentioned this pull request Sep 11, 2018

[AutoPR network/resource-manager] Local september branch merge to master Azure/azure-sdk-for-node#3564

Merged

AutorestCI mentioned this pull request Sep 11, 2018

[AutoPR network/resource-manager] Local september branch merge to master Azure/azure-sdk-for-node#3569

Merged

MikhailTryakhov deleted the local-september-branch branch September 14, 2018 00:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Local september branch merge to master#3862

Local september branch merge to master#3862
dsgouda merged 33 commits intoAzure:masterfrom
MikhailTryakhov:local-september-branch

MikhailTryakhov commented Sep 11, 2018

Uh oh!

AutorestCI commented Sep 11, 2018 •

edited

Loading

Uh oh!

azuresdkci commented Sep 11, 2018

Uh oh!

AutorestCI commented Sep 11, 2018 •

edited

Loading

Uh oh!

MikhailTryakhov commented Sep 11, 2018

Uh oh!

dsgouda left a comment

Uh oh!

AutorestCI commented Sep 11, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 11, 2018 •

edited

Loading

Uh oh!

AutorestCI commented Sep 11, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Conversation

MikhailTryakhov commented Sep 11, 2018

PR information

Quality of Swagger

Uh oh!

AutorestCI commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

azuresdkci commented Sep 11, 2018

Uh oh!

AutorestCI commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

MikhailTryakhov commented Sep 11, 2018

Uh oh!

dsgouda left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Sep 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading

AutorestCI commented Sep 11, 2018 •

edited

Loading