Skip to content

Refactorting DSC resources for preventing conflicts#2705

Merged
fearthecowboy merged 1 commit intoAzure:masterfrom
vrdmr:vameru-refactor-dsc-spec
Mar 20, 2018
Merged

Refactorting DSC resources for preventing conflicts#2705
fearthecowboy merged 1 commit intoAzure:masterfrom
vrdmr:vameru-refactor-dsc-spec

Conversation

@vrdmr
Copy link
Copy Markdown
Member

@vrdmr vrdmr commented Mar 20, 2018 •
edited
Loading

This change is to fix the DSC resources such that they don't conflict with the newer versions of these resources.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@vrdmr vrdmr requested a review from a user March 20, 2018 04:08
@vrdmr vrdmr changed the title Refactorting DSC resources for preventing conflicts Refactoring DSC resources for preventing conflicts Mar 20, 2018
@azuresdkci azuresdkci changed the title Refactoring DSC resources for preventing conflicts Refactorting DSC resources for preventing conflicts Mar 20, 2018
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 20, 2018 •
edited
Loading

Automation for azure-libraries-for-java

Nothing to generate for azure-libraries-for-java

@vrdmr
Copy link
Copy Markdown
Member Author

vrdmr commented Mar 20, 2018

Hi @fearthecowboy. Refactoring the DSC spec as we discussed to circumvent the DSC spec issue. Could you please review and merge this change. Thanks.

@vrdmr vrdmr mentioned this pull request Mar 20, 2018
Merged
10 tasks
@AutorestCI AutorestCI mentioned this pull request Mar 20, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 20, 2018 •
edited
Loading

Automation for azure-sdk-for-node

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-node#2483

@AutorestCI AutorestCI mentioned this pull request Mar 20, 2018
Merged
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 20, 2018 •
edited
Loading

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#1959

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Mar 20, 2018 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@fearthecowboy
Copy link
Copy Markdown
Contributor

fearthecowboy commented Mar 20, 2018

Approved -- we're just moving the models out of the common definitions file and dropping them locally so the next api version can reference old files without getting the wrong models.

@fearthecowboy fearthecowboy merged commit b5273a6 into Azure:master Mar 20, 2018
@vrdmr vrdmr deleted the vameru-refactor-dsc-spec branch July 16, 2018 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiffanyachen tiffanyachen Awaiting requested review from tiffanyachen

@vladbarosan vladbarosan Awaiting requested review from vladbarosan

1 more reviewer

@fearthecowboy fearthecowboy fearthecowboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fearthecowboy fearthecowboy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrdmr @AutorestCI @fearthecowboy