Add optional parameter domain name label scope to public ip address dns settings#23721
Merged
raych1 merged 1 commit intoAzure:mainfrom Apr 28, 2023
tinama0302:matina/addoptionalparametertopipdnssettings
Merged
Add optional parameter domain name label scope to public ip address dns settings#23721raych1 merged 1 commit intoAzure:mainfrom tinama0302:matina/addoptionalparametertopipdnssettings
raych1 merged 1 commit intoAzure:mainfrom
tinama0302:matina/addoptionalparametertopipdnssettings
Conversation
|
Hi, @tinama0302 Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| publicIpAddress.json | 2022-11-01(a1f8e49) | 2022-11-01(main) |
| Rule | Message |
|---|---|
|
The new version has a new property 'domainNameLabelScope' in response that was not found in the old version. New: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L614:7 Old: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L611:7 |
|
The new version has a new optional property 'domainNameLabelScope' that was not found in the old version. New: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L614:7 Old: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L611:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-2022-11 | package-2022-11(a1f8e49) | package-2022-11(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
|
The resource name parameter 'publicIpAddressName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L37 |
|
A 'delete' operation 'PublicIPAddresses_Delete' with x-ms-long-running-operation extension must have a valid terminal success status code 200 or 204. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L38 |
|
The patch operation body parameter schema should contains property 'sku'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L251 |
|
The resource name parameter 'publicIpAddressName' should be defined with a 'pattern' restriction. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L373 |
|
The schema 'PublicIPAddressSku' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L438 |
|
The schema 'PublicIPAddressPropertiesFormat' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L467 |
|
Missing identifier id in array item property Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L490 |
|
The schema 'PublicIPAddress' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L562 |
|
The schema 'PublicIPAddressListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L597 |
|
The schema 'PublicIPAddressDnsSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L613 |
|
The schema 'DdosSettings' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L644 |
|
The schema 'IpTag' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L668 |
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L44 |
|
| The response of operation:'PublicIPAddresses_Get' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L99 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L105 |
|
| The response of operation:'PublicIPAddresses_CreateOrUpdate' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L154 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L160 |
|
| The response of operation:'PublicIPAddresses_UpdateTags' is defined without 'systemData'. Consider adding the systemData to the response. Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L230 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L236 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L295 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L334 |
|
| Parameter 'api-version' is referenced but not defined in the global parameters section of Service Definition Location: Microsoft.Network/stable/2022-11-01/publicIpAddress.json#L380 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️⚠️~[Staging] ServiceAPIReadinessTest: 0 Warnings warning [Detail]
API Test is not triggered due to precheck failure. Check pipeline log for details.
️❌SwaggerAPIView: 0 Errors, 0 Warnings failed [Detail]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️TypeSpec Validation succeeded [Detail] [Expand]
Validation passes for TypeSpec Validation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
Generated ApiView
|
|
NewApiVersionRequired reason: |
This was referenced Apr 25, 2023
This was referenced Apr 25, 2023
Contributor
Author
|
previous PR target on NRP release branch: #23624 |
Contributor
|
Breaking change approved in #23624 |
ankhyk
approved these changes
Apr 27, 2023
Contributor
|
@keryul please merge this approved PR ASAP - we need to continue progress |
This was referenced Apr 28, 2023
This was referenced Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Will enable region by region, for canary region expect to enable in May.
May
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.