Skip to content

New functionality for DSC Extension - Publish-AzureVMDscConfiguration cmdlet(have merge conflicts)#673

Closed
eshaparmar wants to merge 18 commits intodevfrom
unknown repository
Closed

New functionality for DSC Extension - Publish-AzureVMDscConfiguration cmdlet(have merge conflicts)#673
eshaparmar wants to merge 18 commits intodevfrom
unknown repository

Conversation

@eshaparmar
Copy link
Copy Markdown
Contributor

@eshaparmar eshaparmar commented Jul 30, 2015

*We have added new parameters/functionality for the DSC Extension - Publish-AzureVMDscConfiguration cmdlet (both arm/asm).

*Tests for these are written in powershell in our code base and run through our daily CI system

eshaparmar added 14 commits July 20, 2015 14:01
@eshaparmar
Publish new functionality initial changes
a38461a
@eshaparmar
Added -SkipDependencyDetection, AdditionalContent and configdata func…
7917a32 
…tionality to publish
@eshaparmar
Fixed help file for Publish cmdlet
24d9c4d
@eshaparmar
Fixed help file for publish ASM cmdlet
c0d6d80
@eshaparmar
Moved DSC common tests for ASM and ARM to the commands.comman project
1a66005
@eshaparmar
Removed commands.servicemanagement.extensions.test project and moved …
f0d10d4 
…DSC tests to commands.servicemanagement.test
@eshaparmar
Removed not needed resource files.
b96a4fd
@eshaparmar
Code review comments
3238fdb
@eshaparmar
Adding passthru for ASM
8caaa7c
@eshaparmar
Change the default value for PassThru to true
4be2546
@eshaparmar
Improved help for ARM cmdlets
c95ecc3
@eshaparmar
Add dscmetadata.json only when config data,modules or additional cont…
be7e2da 
…ent exist
@eshaparmar
Improve help for arm cmdlets
31c625f
@eshaparmar
Merge branch 'dev' into publish-newfunctionality
a4aa3a2
@azurecla
Copy link
Copy Markdown

azurecla commented Jul 30, 2015

Hi @eshaparmar, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (esparmar). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@eshaparmar
Copy link
Copy Markdown
Contributor Author

eshaparmar commented Jul 30, 2015

@Azure/adx-sdk-team

@stankovski
Copy link
Copy Markdown
Member

stankovski commented Jul 31, 2015

@azuresdkci retest this please

@yugangw-msft
Copy link
Copy Markdown
Contributor

yugangw-msft commented Aug 1, 2015

please resolve the confliction

@eshaparmar
Merge branch 'dev' of https://github.com/Azure/azure-powershell into dev
1a0c17b 
Conflicts:
	src/Common/Commands.Common/Properties/Resources.resx
@stankovski
Copy link
Copy Markdown
Member

stankovski commented Aug 1, 2015

Started on-demand build: http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/42/

yugangw-msft
yugangw-msft reviewed Aug 1, 2015
View reviewed changes
...anagement.Test/UnitTests/Cmdlets/IaaS/Extensions/DSC/GetAzureVMDscExtensionStatusUnitTest.cs
Copy link
Copy Markdown
Contributor

@yugangw-msft yugangw-msft Aug 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license header

@yugangw-msft
Copy link
Copy Markdown
Contributor

yugangw-msft commented Aug 1, 2015

your post check in test failed
http://azuresdkci.cloudapp.net/view/1-AzurePowerShell/job/powershell-on-demand/42/artifact/src/Publish/TestResults/Microsoft.WindowsAzure.Commands.Common.Test.html

@eshaparmar
Copy link
Copy Markdown
Contributor Author

eshaparmar commented Aug 1, 2015

I talked to Denis offline about it. Those tests are working locally but for some reason they fail now on build system. I have disabled those tests temporarily. Please merge this PR

@yugangw-msft yugangw-msft changed the title New functionality for DSC Extension - Publish-AzureVMDscConfiguration cmdlet New functionality for DSC Extension - Publish-AzureVMDscConfiguration cmdlet(have merge conflicts) Aug 1, 2015
@eshaparmar eshaparmar mentioned this pull request Aug 3, 2015
Merged
@eshaparmar
Copy link
Copy Markdown
Contributor Author

eshaparmar commented Aug 3, 2015

Closing this PR and created a new one #689

@eshaparmar eshaparmar closed this Aug 3, 2015
@eshaparmar eshaparmar deleted the publish-newfunctionality branch August 12, 2015 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eshaparmar @azurecla @stankovski @yugangw-msft