Update Set-AzureRmVMDiskEncryptionExtension.md#6100
Merged
cormacpayne merged 2 commits intoAzure:previewfrom May 3, 2018
Merged
Update Set-AzureRmVMDiskEncryptionExtension.md#6100cormacpayne merged 2 commits intoAzure:previewfrom
cormacpayne merged 2 commits intoAzure:previewfrom
Conversation
I happened to be testing a similar script and think I ran across a few small issues with the examples. 1. $KEKName not set in examples 3&4 2. New-AzureRmADApplication seems to use -CertValue rather than -KeyValue and -KeyType https://docs.microsoft.com/en-us/powershell/module/azurerm.resources/new-azurermadapplication?view=azurermps-5.7.0 3. Looks like the KEK bit is missing from Set-AzureRmVMDiskEncryptionExtension in Example 4 for cert + KEK.
|
Can one of the admins verify this patch? |
Contributor
Author
|
I just realized I stuck this in the preview branch rather than master (oops, I didn't verify, sorry). Let me know if you want me to close this PR and just do a new one against master |
Member
|
@azuresdkci add to whitelist |
Member
|
@mestew Hey Meghan, thanks for creating this PR 😀 I pushed a commit to your fork/branch that updates another @ejarvi Hey Eric, would you mind reviewing the change made to this markdown file when you get the chance? |
cormacpayne
approved these changes
May 3, 2018
Contributor
|
Yes - reviewed the changes and they look correct, thank you Meghan for catching this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I happened to be testing a similar script and think I ran across a few small issues with the examples.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule