Skip to content

Ignite ReservedIP/Multivip fixes for powershell with tests#577

Merged
markcowl merged 13 commits intoAzure:devfrom
avijitgupta:dev
Jul 10, 2015
Merged

Ignite ReservedIP/Multivip fixes for powershell with tests#577
markcowl merged 13 commits intoAzure:devfrom
avijitgupta:dev

Conversation

@avijitgupta
Copy link
Copy Markdown

@avijitgupta avijitgupta commented Jul 9, 2015

This depends on nuget package Microsoft.WindowsAzure.Management.Network.7.0.3

The MAML PR was merged

Azure/azure-sdk-for-net#1213

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Jul 9, 2015

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

azurecla commented Jul 9, 2015

Hi @avijitgupta, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (avgupt). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

huangpf
huangpf reviewed Jul 9, 2015
View reviewed changes
...viceManagement/Network/Commands.Network.Test/ScenarioTests/MultiVip/MultiVipScenarioTests.cs Outdated
Copy link
Copy Markdown
Contributor

@huangpf huangpf Jul 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment Header?

Copy link
Copy Markdown
Author

@avijitgupta avijitgupta Jul 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out

@hovsepm
Copy link
Copy Markdown
Contributor

hovsepm commented Jul 9, 2015

@azuresdkci add to whitelist

@DeepakRajendranMsft
Copy link
Copy Markdown
Contributor

DeepakRajendranMsft commented Jul 9, 2015

Added some comments to codeflow. LGTM except that the storage update needs to happen in all other projects

@avijitgupta
Copy link
Copy Markdown
Author

avijitgupta commented Jul 9, 2015

Fixed Deepak's comments in codeflow

@avijitgupta
Copy link
Copy Markdown
Author

avijitgupta commented Jul 10, 2015

Reduced the length of recorded test path

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Jul 10, 2015

@azuresdkci retest this please

@markcowl
Copy link
Copy Markdown
Member

markcowl commented Jul 10, 2015

@avijitgupta Please add changes to changelog.txt

@avijitgupta
Copy link
Copy Markdown
Author

avijitgupta commented Jul 10, 2015

Added changes to changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@avijitgupta @azuresdkci @azurecla @hovsepm @DeepakRajendranMsft @markcowl @huangpf