Skip to content

[Az.Applicationinsights] enable common parameter in get-azapplicationinsights#23663

Merged
dolauli merged 1 commit intoAzure:generationfrom
NoriZC:gen/application-insights
Dec 8, 2023
Merged

[Az.Applicationinsights] enable common parameter in get-azapplicationinsights#23663
dolauli merged 1 commit intoAzure:generationfrom
NoriZC:gen/application-insights

Conversation

@NoriZC
Copy link
Copy Markdown
Contributor

@NoriZC NoriZC commented Dec 5, 2023

Description

Fix #23609

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Dec 5, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzApplicationInsightsMyWorkbook Get-AzApplicationInsightsMyWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsMyWorkbook Get-AzApplicationInsightsMyWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbook Get-AzApplicationInsightsWorkbook Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbook Get-AzApplicationInsightsWorkbook changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbookRevision Get-AzApplicationInsightsWorkbookRevision Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbookRevision Get-AzApplicationInsightsWorkbookRevision changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzApplicationInsightsWorkbookTemplate Get-AzApplicationInsightsWorkbookTemplate Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzApplicationInsightsWorkbookTemplate Get-AzApplicationInsightsWorkbookTemplate changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzApplicationInsightsWorkbookTemplateGalleryObject New-AzApplicationInsightsWorkbookTemplateGalleryObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzApplicationInsightsWorkbookRevision 1 1 Is_Alias fl is an alias of 'Format-List'. fl Use formal name 'Format-List' of the alias 'fl'.
⚠️ New-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context.
⚠️ Set-AzApplicationInsightsContinuousExport 1 1 Unassigned_Variable New-AzStorageContainerSASToken -Context $context is a null-valued parameter value. -Context Assign value for $context.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ApplicationInsights. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows

@NoriZC NoriZC assigned NoriZC and dolauli and unassigned NoriZC Dec 5, 2023
@dolauli dolauli merged commit 7235772 into Azure:generation Dec 8, 2023
@NoriZC NoriZC deleted the gen/application-insights branch December 25, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants