Skip to content

[ConnectedMachine] release preview version 2023-10-03#23575

Merged
dolauli merged 16 commits intoAzure:generationfrom
yaotongms:generation
Dec 7, 2023
Merged

[ConnectedMachine] release preview version 2023-10-03#23575
dolauli merged 16 commits intoAzure:generationfrom
yaotongms:generation

Conversation

@yaotongms
Copy link
Copy Markdown
Member

@yaotongms yaotongms commented Nov 27, 2023

Description

This release is targeting version 2023-10-03-preview of ConnectedMachine. You will see all commands from the previous version with the following new commands:

  • Get-AzConnectedMachineRunCommand: get run commands of an Azure Arc-Enabled Server
  • New-AzConnectedMachineRunCommand: create a run command of an Azure Arc-Enabled Server
  • Remove-AzConnectedMachineRunCommand: remove a run command of an Azure Arc-Enabled Server
  • Update-AzConnectedMachineRunCommand: update a run command of an Azure Arc-Enabled Server

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 27, 2023

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ConnectedMachine
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ Get-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Get-AzConnectedPrivateLinkScope 2 1 Unassigned_Variable Get-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedMachine. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@dolauli dolauli self-assigned this Dec 4, 2023
@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented Dec 4, 2023

@yaotongms Please fix the CI errors.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 4, 2023

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@yaotongms
Copy link
Copy Markdown
Member Author

@yaotongms Please fix the CI errors.

CI errors fixed

@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented Dec 5, 2023

@yaotongms Please fix the CI errors.

CI errors fixed
@yaotongms
Test actually still fails actually. The CI shows pass is because of the issue of CI pipeline.

@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented Dec 6, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli merged commit f6d66c6 into Azure:generation Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants