Skip to content

[Az.ConnectedKubernetes] support proxy environments and fix issues (from generation)#20955

Merged
BethanyZhou merged 18 commits intoAzure:generationfrom
yinghsugn:lua/fix/connectedk8s2
Feb 17, 2023
Merged

[Az.ConnectedKubernetes] support proxy environments and fix issues (from generation)#20955
BethanyZhou merged 18 commits intoAzure:generationfrom
yinghsugn:lua/fix/connectedk8s2

Conversation

@yinghsugn
Copy link
Copy Markdown
Contributor

@yinghsugn yinghsugn commented Feb 17, 2023 •
edited
Loading

Description

  • Added optional configs (-HttpProxy, -HttpsProxy, -NoProxy, -ProxyCert) for cmdlet New-AzConnectedKubernetes.
  • Added optional configs (-ContainerLogPath, -DisableAutoUpgrade, -NoWait, -OnboardingTimeout) for cmdlet New-AzConnectedKubernetes.
  • Fixed invalid URI issue with display name of location for cmdlet New-AzConnectedKubernetes.
  • Fixed response can't be parsed issue with UseBasicParsing for cmdlet New-AzConnectedKubernetes.

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

Nickcandy and others added 11 commits February 17, 2023 12:55
@Nickcandy @yinghsugn
OOB of Az.ConnectedKubernetes (Azure#20904)
f5d29cc 
* Fix/connectedk8s ps5 (Azure#20603)

* Create RSAHelper.ps1

* Update New-AzConnectedKubernetes.ps1

* Add try-catch and update function parameters

* Update New-AzConnectedKubernetes.ps1

* [Az.ConnectedKubernetes] Update ChangeLog  (Azure#20649)

* Update RSAHelper.ps1 (coding style)

* Update ChangeLog.md

* upgrade Az.ConnectedKubernetes from 0.7.0 to 0.7.1

---------

Co-authored-by: Ann Lu <112682982+yinghsugn@users.noreply.github.com>
@yinghsugn
Fix Invoke-WebRequest in Win10 issue
b21c82a
@yinghsugn
Add optional settings (+2 squashed commit)
056eb87 
Squashed commit:

[37a75ce5980] Add optional settings

[f90cd1a98ee] Add optional settings
@yinghsugn
Install azure-arc helm release in azure-arc-release namespace (+1 squ…
36724ae 
…ashed commits)

Squashed commits:

[49e9e01caf3] Install azure-arc helm release in azure-arc-release namespace (+1 squashed commits)

Squashed commits:

[9662ecff989] Install azure-arc helm release in azure-arc-release namespace
@yinghsugn
Fix RSAHelper format
8005161
@yinghsugn
Add Proxy settings (+1 squashed commits)
af467c0 
Squashed commits:

[28ff1d7f8cf] Add Proxy settings (+4 squashed commit)

Squashed commit:

[cdfe615ad63] Update warning messages

[5d46ec26806] Check credential

[db0351e75f5] Update parameter description

[79bf2b15c29] Modify parameter type
@yinghsugn
Fix Invalid URI issue when passing diaplsy name of location (+1 squas…
e656b8b 
…hed commits)

Squashed commits:

[c893de7a1b5] Fix Invalid URI issue when passing diaplsy name of location (+1 squashed commits)

Squashed commits:

[bc81f1915fb] Fix Invalid URI issue when passing diaplsy name of location
@yinghsugn
Update examples
8d5c31a
@yinghsugn
Update parameter names and docs
22bea89
@yinghsugn
Move RSAHelper to custom
0d640d3
@yinghsugn
Update docs
0a477c8
BethanyZhou
BethanyZhou suggested changes Feb 17, 2023
View reviewed changes
src/ConnectedKubernetes/docs/Get-AzConnectedKubernetesUserCredential.md Outdated


`PROPERTY <IListClusterUserCredentialProperties>`: .
PROPERTY <IListClusterUserCredentialProperties>: .
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deleting is caused your autorest version. please run autorest --reset then re-run autorest, ./build-module.ps1 to upgrade autorest

Copy link
Copy Markdown
Contributor Author

@yinghsugn yinghsugn Feb 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
After "autorest --reset, autoreset, ./build-module.ps1" commands, the formats are recovered.

BethanyZhou
BethanyZhou previously approved these changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Nickcandy
Copy link
Copy Markdown
Contributor

Nickcandy commented Feb 17, 2023

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Feb 17, 2023

Azure Pipelines successfully started running 3 pipeline(s).

BethanyZhou
BethanyZhou reviewed Feb 17, 2023
View reviewed changes
BethanyZhou
BethanyZhou approved these changes Feb 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethanyZhou BethanyZhou merged commit e00d493 into Azure:generation Feb 17, 2023
@BethanyZhou BethanyZhou mentioned this pull request Feb 17, 2023
Merged
1 task
@yinghsugn yinghsugn deleted the lua/fix/connectedk8s2 branch February 21, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@BethanyZhou BethanyZhou BethanyZhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yinghsugn @Nickcandy @BethanyZhou