-PerformancePlus for New-AzDiskConfig#20937
Merged
BethanyZhou merged 3 commits intomainfrom Feb 17, 2023
Merged
Conversation
BethanyZhou
reviewed
Feb 16, 2023
| Mandatory = false, | ||
| ValueFromPipelineByPropertyName = true, | ||
| HelpMessage = "Set this flag to true to get a boost on the performance target of the disk deployed, see here on the respective performance target. This flag can only be set on disk creation time and cannot be disabled after enabled.")] | ||
| public bool? PerformancePlus { get; set; } |
Contributor
There was a problem hiding this comment.
We'd like suggest to use switch parameter for PerformancePlus in New-Az* command
Contributor
Author
There was a problem hiding this comment.
yes, switchParameter would make more sense but all the boolean properties for Disk in this cmdlet New-AzDiskConfig are defined as boolean and not Switch. So I wanted to keep it consistent within this cmdlet.
I think it's better than having one boolean property be switch while ~3 others are all boolean for this cmdlet.
Contributor
Author
There was a problem hiding this comment.
BethanyZhou
suggested changes
Feb 16, 2023
Contributor
BethanyZhou
left a comment
There was a problem hiding this comment.
Suppress false positive for
D:\a\_work\1\s\artifacts//StaticAnalysisResults\SignatureIssues.csv Errors
"Module","ClassName","Target","Severity","ProblemId","Description","Remediation"
"Az.Compute","Microsoft.Azure.Commands.Compute.Automation.NewAzureRmDiskConfigCommand","New-AzDiskConfig","1","8410","Parameter PerformancePlus of cmdlet New-AzDiskConfig does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
Contributor
Author
thank you. suppressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.