Merged
Conversation
isra-fel
reviewed
Feb 15, 2023
Member
isra-fel
left a comment
There was a problem hiding this comment.
Breaking changes should have a targeted date. Will it happen in our next breaking change relase this May?
Contributor
Author
Hi yeming, First, we will release module with breaking change. If the steps are correct. Our target date is May. |
BethanyZhou
reviewed
Feb 17, 2023
| /// <summary> | ||
| /// 'Set-AzRelayNamespace' Cmdlet updates the specified Relay Namespace | ||
| /// </summary> | ||
| [GenericBreakingChange("Set-AzRelayNamespace will be removed in an upcoming breaking change release, you can use Update-AzRelayNamespace in a future release")] |
Contributor
There was a problem hiding this comment.
Please add a target date or target version in breaking change message.
BethanyZhou
suggested changes
Feb 17, 2023
Contributor
BethanyZhou
left a comment
There was a problem hiding this comment.
The target version should be 2.0.0 for Az.Relay
BethanyZhou
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.