Skip to content

Add missing online version#20916

Merged
isra-fel merged 6 commits intomainfrom
wyunchi/help/event-grid
Feb 15, 2023
Merged

Add missing online version#20916
isra-fel merged 6 commits intomainfrom
wyunchi/help/event-grid

Conversation

@wyunchi-ms
Copy link
Copy Markdown
Contributor

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@BethanyZhou
Copy link
Copy Markdown
Contributor

BethanyZhou commented Feb 14, 2023

let's leave following errors to service owner and ask for force-merge

 Target      : Get-AzCdnProfile.md
  Description : No synopsis found
  
  Target      : Get-AzCdnProfile.md
  Description : No description found
  
  Target      : Get-AzFrontDoorCdnProfile.md
  Description : No synopsis found
  
  Target      : Get-AzFrontDoorCdnProfile.md
  Description : No description found
  
  Target      : New-AzFrontDoorCdnRule.md
  Description : No examples found
  
  Target      : Get-AzMLWorkspaceConnection.md
  Description : No synopsis found
  
  Target      : Get-AzMLWorkspaceConnection.md
  Description : No description found
  
  Target      : New-AzMLWorkspaceConnection.md
  Description : No synopsis found
  
  Target      : New-AzMLWorkspaceConnection.md
  Description : No description found
  
  Target      : Remove-AzMLWorkspaceConnection.md
  Description : No synopsis found
  
  Target      : Remove-AzMLWorkspaceConnection.md
  Description : No description found

Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR aims at fixing online version issues. We don't suppress example issues reported by static analyzer because we want to left them to service team. No other issues are reported @isra-fel please help force-merge.

@isra-fel isra-fel merged commit d7880ae into main Feb 15, 2023
@isra-fel isra-fel deleted the wyunchi/help/event-grid branch February 15, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants