{AzureFrontDoor} fixes Azure/azure-powershell#20870 Adding Tag parameter to New-AzFrontDoorWafPolicy#20908
Merged
BethanyZhou merged 6 commits intomainfrom Feb 15, 2023
Merged
Conversation
…WafPolicy fixes #20870 Adding Tag parameter to New-AzFrontDoorWafPolicy This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.
Member
|
/azp run azure-powershell - security-tools |
Contributor
|
Azure Pipelines successfully started running 1 pipeline(s). |
BethanyZhou
suggested changes
Feb 13, 2023
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
Co-authored-by: Beisi Zhou <zhoubeisi@gmail.com>
BethanyZhou
reviewed
Feb 15, 2023
Contributor
BethanyZhou
left a comment
There was a problem hiding this comment.
I'm wondering if this parameter should be added into Update-AzFrontDoorWafPolicy as well. @navba-MSFT what's your thought
Contributor
Author
@BethanyZhou For updating the tags alone, the recommendation would be to use Update-AzTag command. |
Contributor
|
we'd better allow customer to update other properties together with tags. |
BethanyZhou
approved these changes
Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20870
Adding Tag parameter to New-AzFrontDoorWafPolicy
This PR Allow the passing of tags when creating a new Azure Front Door Waf Policy resource. Currently, tags can be added in the portal but not via powershell for the FrontDoor WAF policy.
Description
Checklist
CONTRIBUTING.mdand reviewed the following information:generationbranch.ChangeLog.mdfile(s) appropriatelyChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader in the past tense. Add changelog in description section if PR goes intogenerationbranch.ChangeLog.mdif no new release is required, such as fixing test case only.