Skip to content

Servicebus Namespace with Scaleset Feature#20807

Merged
BethanyZhou merged 2 commits intoAzure:generationfrom
schaudhari6254888:Scaleset
Feb 14, 2023
Merged

Servicebus Namespace with Scaleset Feature#20807
BethanyZhou merged 2 commits intoAzure:generationfrom
schaudhari6254888:Scaleset

Conversation

@schaudhari6254888
Copy link
Copy Markdown
Member

Description

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@schaudhari6254888 schaudhari6254888 changed the base branch from main to generation February 1, 2023 10:39
@schaudhari6254888 schaudhari6254888 marked this pull request as ready for review February 13, 2023 11:03
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants