[Az.ContainerRegistry] fix parameter type for update-azcontainerregistryrepository#17984
Merged
wyunchi-ms merged 1 commit intoAzure:mainfrom Apr 29, 2022
Merged
Conversation
wyunchi-ms
approved these changes
Apr 29, 2022
8 tasks
BethanyZhou
reviewed
Jul 15, 2022
| [Parameter(Mandatory = false, HelpMessage = "Delete enable.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public bool DeleteEnabled { get; set; } | ||
| public bool? DeleteEnabled { get; set; } |
Contributor
There was a problem hiding this comment.
No idea why this breaking change was not detected, it causes other PR's CI failed. Could you have a look? @wyunchi-ms @VeryEarly
Member
There was a problem hiding this comment.
Given that the breaking changes were not detected, and the CI ran suspeciously fast (azure-powershell - powershell-core
succeeded on 26 Apr in 17m 28s), I guess it was caused by the throtling of GitHub API, causing CI unable to get the list of changed files, so some of the steps were skipped.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$false was passed when optional parameter was not provided for type bool, change to bool? which reflect desired behavior.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added