Skip to content

Fix Az.CosmosDB Syntax Errors#17547

Merged
isra-fel merged 3 commits intoAzure:mainfrom
v-yuzhichen:CosmosDB-Syntax
Apr 6, 2022
Merged

Fix Az.CosmosDB Syntax Errors#17547
isra-fel merged 3 commits intoAzure:mainfrom
v-yuzhichen:CosmosDB-Syntax

Conversation

@v-yuzhichen
Copy link
Copy Markdown
Contributor

@v-yuzhichen v-yuzhichen commented Mar 22, 2022

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

ziyuezh576
ziyuezh576 reviewed Mar 22, 2022
View reviewed changes
src/CosmosDB/CosmosDB/help/New-AzCosmosDBAccount.md Outdated
### Example 3
```powershell
New-AzCosmosDBAccount -ResourceGroupName resourceGroupName -Name restored-account-name -Location "West US" -FromPointInTimeBackup -SourceDatabaseAccountName source-database-account-name -RestoreTimesampInUtc 2020-07-20T17:19:25+0000
New-AzCosmosDBAccount -ResourceGroupName resourceGroupName -Name restored-account-name -Location "West US" -FromPointInTimeBackup -Name source-database-account-name
Copy link
Copy Markdown
Contributor

@ziyuezh576 ziyuezh576 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two "-Name" parameters.

src/CosmosDB/CosmosDB/help/New-AzCosmosDBAccount.md Outdated
### Example 2
```powershell
New-AzCosmosDBAccount -ResourceGroupName resourceGroupName -Name restored-account-name -Location "West US" -FromPointInTimeBackup -RestoreSourceId /subscriptions/{subscriptionId}/providers/Microsoft.DocumentDB/restorableDatabaseAccounts/{instance-id} -RestoreTimesampInUtc 2020-07-20T17:19:25+0000
New-AzCosmosDBAccount -ResourceGroupName resourceGroupName -Name restored-account-name -Location "West US" -FromPointInTimeBackup
Copy link
Copy Markdown
Contributor

@ziyuezh576 ziyuezh576 Mar 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange, it can associate parameter name "RestoreTimestampInUtc", but it do be not in the parameters list.

Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou Mar 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As RestoreTimestampInUtc is bounded as dynamic parameter

azure-powershell/src/CosmosDB/CosmosDB/CosmosDBAccount/NewAzCosmosDBAccount.cs

Line 277 in 371a678

restoreContext = new RestoreRequestDynamicParameters();

azure-powershell/src/CosmosDB/CosmosDB/CosmosDBAccount/RestoreRequestDynamicParameters.cs

Lines 28 to 35 in 864448b

[Parameter(Mandatory = false, HelpMessage = Constants.RestoreSourceIdHelpMessage)]
public string SourceRestorableDatabaseAccountId { get; set; }
[Parameter(Mandatory = false, HelpMessage = Constants.RestoreSourceDatabaseAccountNameHelpMessage)]
public string SourceDatabaseAccountName { get; set; }
[Parameter(Mandatory = true, HelpMessage = Constants.RestoreTimestampHelpMessage)]
public DateTimeOffset RestoreTimestampInUtc { get; set; }

ziyuezh576
ziyuezh576 previously approved these changes Mar 23, 2022
View reviewed changes
@isra-fel
Copy link
Copy Markdown
Member

isra-fel commented Mar 31, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Mar 31, 2022

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel assigned isra-fel and unassigned ziyuezh576 Mar 31, 2022
@isra-fel
Copy link
Copy Markdown
Member

isra-fel commented Apr 3, 2022

CI will be fixed by #17708

@isra-fel
Copy link
Copy Markdown
Member

isra-fel commented Apr 6, 2022

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Apr 6, 2022

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel isra-fel merged commit 1851f5a into Azure:main Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

@CaptainFanZzz CaptainFanZzz Awaiting requested review from CaptainFanZzz

+2 more reviewers

@BethanyZhou BethanyZhou BethanyZhou left review comments

@ziyuezh576 ziyuezh576 ziyuezh576 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@isra-fel isra-fel

Labels

Doc - Reference Waiting for CI :shipit:

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@v-yuzhichen @isra-fel @BethanyZhou @ziyuezh576