Virtual Wan P2S MultiPool feature changes#17032
Conversation
|
CI failed: The type or namespace name 'IConfigurationPolicyGroupsOperations' could not be found (are you missing a using directive or an assembly reference?) Please have a look. |
| Assert-AreEqual "Succeeded" $P2SVpnGateway.ProvisioningState | ||
| Assert-AreEqual 1 @($P2SVpnGateway.CustomDnsServers).Count | ||
| Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] | ||
| Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] |
There was a problem hiding this comment.
| Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] | |
| Assert-AreEqual "7.7.7.7" $P2SVpnGateway.CustomDnsServers[0] |
| $job = Reset-AzP2sVpnGateway -P2SVpnGateway $P2SVpnGateway -AsJob | ||
| $job | Wait-Job | ||
| $actual = $job | Receive-Job |
There was a problem hiding this comment.
Please correct indents.
|
@isra-fel Incorporate review comment. Please take a look. |
Waiting for latest network SDK generation. |
|
Generally looks good. Please regenerate help documents and resolve the conflicts. |
Done. @isra-fel Please take a look. Thanks! |
isra-fel
left a comment
There was a problem hiding this comment.
This file src/Network/Network/help/Az.Network.md is supposed to be updated when introducing new cmdlets.
Please make sure to use -RefreshModulePage when regenerating helps, see https://github.com/Azure/azure-powershell/blob/main/documentation/development-docs/help-generation.md#updating-all-markdown-files-in-a-module
Let me update it. Thanks. |
Incorporated review comments & included latest test recording as well. @isra-fel Please take a look and help approve this PR. Thanks! |
… nilamd_network-2021-08-01
|
/azp run azure-powershell - security-tools |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be addedhttps://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1127