Skip to content

Initial commit for the Websites commandlets for ARM#154

Merged
stankovski merged 3 commits intoAzure:devfrom
NaveenGoli:dev
Feb 25, 2015
Merged

Initial commit for the Websites commandlets for ARM#154
stankovski merged 3 commits intoAzure:devfrom
NaveenGoli:dev

Conversation

@NaveenGoli
Copy link
Copy Markdown
Contributor

@NaveenGoli NaveenGoli commented Feb 10, 2015

No description provided.

@azuresdkci
Copy link
Copy Markdown

azuresdkci commented Feb 10, 2015

Can one of the admins verify this patch?

@azurecla
Copy link
Copy Markdown

azurecla commented Feb 10, 2015

Hi @NaveenGoli, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (ngoli). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, or work for Microsoft Open Technologies, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

amitapl
amitapl reviewed Feb 10, 2015
View reviewed changes
src/AzurePowershell.sln Outdated
Copy link
Copy Markdown

@amitapl amitapl Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you remove this project?

@amitapl
Copy link
Copy Markdown

amitapl commented Feb 10, 2015

Is the file src/ResourceManager/Websites/Commands.Websites/MSSharedLibKey.snk required in the repo?

galiniliev
galiniliev reviewed Feb 10, 2015
View reviewed changes
src/ResourceManager/Websites/Commands.Websites/Utilities/WebsitesClient.cs Outdated
Copy link
Copy Markdown

@galiniliev galiniliev Feb 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra new lines

@ogail
Copy link
Copy Markdown
Contributor

ogail commented Feb 10, 2015

@azuresdkci add to whitelist

@NaveenGoli
Copy link
Copy Markdown
Contributor Author

NaveenGoli commented Feb 11, 2015

I have incorporated all the feedback changes. please review..

amitapl
amitapl reviewed Feb 11, 2015
View reviewed changes
src/ResourceManager/Websites/Commands.Websites/Cmdlets/NewAzureWebsites.cs
Copy link
Copy Markdown

@amitapl amitapl Feb 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have some extra \n throughout

Copy link
Copy Markdown
Contributor Author

@NaveenGoli NaveenGoli Feb 12, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@amitapl
Copy link
Copy Markdown

amitapl commented Feb 12, 2015

looks good

@NaveenGoli
Copy link
Copy Markdown
Contributor Author

NaveenGoli commented Feb 12, 2015

Will this be merged? AFAI can see, Microsoft.Azure.Commands.ScenarioTest.SqlTests.SecurityTests has no relation to websites code changes.. please let me know what the next steps are..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@NaveenGoli @azuresdkci @azurecla @amitapl @ogail @matt-gibbs @yadavbdev @galiniliev @stankovski