Skip to content

[Compute] Adding Set-AzVmUefi, Set-AzVmssUefi, Set-AzVmSecurityType, Set-AzVmssSecurityType to support Trusted Launch#14479

Merged
wyunchi-ms merged 6 commits intoAzure:release-2021-03-23from
sf-76:sirlin/trustedlaunch
Mar 17, 2021
Merged

[Compute] Adding Set-AzVmUefi, Set-AzVmssUefi, Set-AzVmSecurityType, Set-AzVmssSecurityType to support Trusted Launch#14479
wyunchi-ms merged 6 commits intoAzure:release-2021-03-23from
sf-76:sirlin/trustedlaunch

Conversation

@sf-76
Copy link
Copy Markdown
Contributor

@sf-76 sf-76 commented Mar 8, 2021

Description

Adding 4 new cmdlets to Az.Compute

Set-AzVmSecurityType
Set-AzVmUefi
Set-AzVmssSecurityType
Set-AzVmssUefi

These four cmdlets will enable customers to enable Trusted Launch on their VMs and VMSS.

Checklist

@wyunchi-ms
Copy link
Copy Markdown
Contributor

Please add help files for these new cmdlets.

@wyunchi-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sf-76 sf-76 added this to the S184 (2021-03-23) milestone Mar 15, 2021
@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 15, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sf-76 sf-76 force-pushed the sirlin/trustedlaunch branch from a4c1580 to ce28ea6 Compare March 15, 2021 23:33
@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 16, 2021

@wyunchi-ms, I seem to be running into some issues with the Static Analysis portion of the pipeline, I'm not sure where it is going wrong. I've added the 4 cmdlets to the SignatureIssues.csv like I did for the PRs in the Azure-PowerShell-Pr repo but it seems like it is unable to parse the whole .csv file.

@sf-76 sf-76 force-pushed the sirlin/trustedlaunch branch from 4d6d403 to 717b124 Compare March 16, 2021 01:50
@wyunchi-ms
Copy link
Copy Markdown
Contributor

wyunchi-ms commented Mar 16, 2021

You are missing the double quotes ".
And I think ShouldProcess is necessary. Could you please support it?

@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 16, 2021

You are missing the double quotes ".
And I think ShouldProcess is necessary. Could you please support it?

In my older PR in the private repo, Isra-fel said that in-memory cmdlets do not support ShouldProcess. https://github.com/Azure/azure-powershell-pr/pull/576#discussion_r502749568

The cmdlets that config a VM that support ShouldProcess are the Remove-cmdlets
image

@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 16, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 16, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@sf-76
Copy link
Copy Markdown
Contributor Author

sf-76 commented Mar 17, 2021

@wyunchi-ms looks like the az pipelines pass now after fixing the SignaturesIssues.csv. Is there any chance this PR can still be included in the 3/23 release?

@wyunchi-ms
Copy link
Copy Markdown
Contributor

You are missing the double quotes ".
And I think ShouldProcess is necessary. Could you please support it?

In my older PR in the private repo, Isra-fel said that in-memory cmdlets do not support ShouldProcess. Azure/azure-powershell-pr#576 (comment)

The cmdlets that config a VM that support ShouldProcess are the Remove-cmdlets
image

It's OK for in-memory cmdlet.

@wyunchi-ms wyunchi-ms changed the base branch from master to release-2021-03-23 March 17, 2021 02:36
@wyunchi-ms wyunchi-ms merged commit 1dff131 into Azure:release-2021-03-23 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants