Skip to content

[KeyVault] support async API design of security domain#14443

Merged
isra-fel merged 1 commit intomasterfrom
yeming/kv-async-sd
Mar 11, 2021
Merged

[KeyVault] support async API design of security domain#14443
isra-fel merged 1 commit intomasterfrom
yeming/kv-async-sd

Conversation

@isra-fel
Copy link
Copy Markdown
Member

@isra-fel isra-fel commented Mar 5, 2021

Description

KeyVault will update their API design of security domain import/export to be asynchronous.
This PR make sure our cmdlet won't break when the API change takes place.

Change list:

  • Support both sync and async API design
  • Improved some error handling to throw AzPS*Exception
  • Supported cancelling cmdlet execution by ctrl-C
  • Added debug log

Testing:
I tested on public cloud for the old API. Will ask KeyVault team's help to test in dogfood.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Mar 5, 2021
@isra-fel
Copy link
Copy Markdown
Member Author

isra-fel commented Mar 5, 2021

@isra-fel isra-fel force-pushed the yeming/kv-async-sd branch 4 times, most recently from 65bffe9 to 6991395 Compare March 10, 2021 07:45
@isra-fel isra-fel assigned BethanyZhou and unassigned isra-fel Mar 10, 2021
@isra-fel isra-fel marked this pull request as ready for review March 10, 2021 08:42
@isra-fel isra-fel force-pushed the yeming/kv-async-sd branch from 6991395 to 8010d44 Compare March 11, 2021 07:05
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit 683c36c into master Mar 11, 2021
@isra-fel isra-fel deleted the yeming/kv-async-sd branch March 11, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants