VNG multi Auth support#14441
Merged
wyunchi-ms merged 13 commits intoAzure:network-novemberfrom Mar 10, 2021
Merged
Conversation
Contributor
|
Please resolve the conflicts and security issue. |
Nilambari
reviewed
Mar 10, 2021
Nilambari
reviewed
Mar 10, 2021
src/Network/Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs
Show resolved
Hide resolved
Nilambari
reviewed
Mar 10, 2021
src/Network/Network/VirtualNetworkGateway/UpdateAzureVirtualNetworkGatewayCommand.cs
Show resolved
Hide resolved
wyunchi-ms
approved these changes
Mar 10, 2021
Contributor
|
LGTM |
Nilambari
reviewed
Mar 10, 2021
src/Network/Network/VirtualNetworkGateway/UpdateAzureVirtualNetworkGatewayCommand.cs
Show resolved
Hide resolved
Nilambari
reviewed
Mar 10, 2021
Member
Nilambari
left a comment
There was a problem hiding this comment.
There are 3 nuget packages added under LocalFeed but its not consumed. If its not needed, remove them.
Nilambari
approved these changes
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added