Azure Firewall - Data PIP removal for FT firewal#14138
Merged
VeryEarly merged 10 commits intoAzure:network-novemberfrom Mar 16, 2021
tinawu6:yuhwu/datapipremoval
Merged
Azure Firewall - Data PIP removal for FT firewal#14138VeryEarly merged 10 commits intoAzure:network-novemberfrom tinawu6:yuhwu/datapipremoval
VeryEarly merged 10 commits intoAzure:network-novemberfrom
tinawu6:yuhwu/datapipremoval
Conversation
|
Thank you for your contribution tinawu6! We will review the pull request and get back to you soon. |
|
|
iatodoro
reviewed
Mar 2, 2021
iatodoro
reviewed
Mar 2, 2021
iatodoro
reviewed
Mar 2, 2021
iatodoro
reviewed
Mar 2, 2021
Member
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
As we talked in mail, please use the link https://aka.ms/AzureGithub to join Azure orgnization on Github. It marks you as a trusted developer so the CI pipelines can trigger automatically. @tinawu6 |
isra-fel
requested changes
Mar 15, 2021
Member
There was a problem hiding this comment.
Hi @tinawu6 , changing cmdlet syntax requires you to regenerate help document
In this case, you should expect New-AzFirewall.md to be updated after regeneration.
Other changes look good to me
isra-fel
approved these changes
Mar 16, 2021
VeryEarly
approved these changes
Mar 16, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature: Enable firewall to be created and reconfigured without customer providing public IP.
This change relaxes the validation that enforces user to add a data PIP when creating a firewall.
The new supported scenarios are:
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added