Skip to content

Modified SmokeTest/RmCoreSmokeTests.ps1.#13883

Merged
dingmeng-xue merged 7 commits intoAzure:masterfrom
LucasYao93:lucas/SmokeTest
Jan 18, 2021
Merged

Modified SmokeTest/RmCoreSmokeTests.ps1.#13883
dingmeng-xue merged 7 commits intoAzure:masterfrom
LucasYao93:lucas/SmokeTest

Conversation

@LucasYao93
Copy link
Copy Markdown
Contributor

@LucasYao93 LucasYao93 commented Jan 6, 2021 •
edited
Loading

Description

Modified SmokeTest/RmCoreSmokeTests.ps1.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou
Copy link
Copy Markdown
Contributor

BethanyZhou commented Jan 6, 2021

@LucasYao93 It's suggested to run the smoke test script locally. And I think it's unnecessary to convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun} currently, could you revert these changes?

@LucasYao93
Copy link
Copy Markdown
Contributor Author

LucasYao93 commented Jan 6, 2021

It's suggested to run the smoke test script locally. And I think it's unnecessary to convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun} currently, could you revert these changes?

Hi @BethanyZhou ,
I have ran the smoke test script locally which passed. Dingmeng suggested convert {Verb}-AzureRm{Noun} to {Verb}-Az{Noun}, Because the command format should be {Verb}-Az{Noun}.

Thanks

BethanyZhou
BethanyZhou suggested changes Jan 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable-AzureRmAlias handles {Verb}-AzureRm{Noun} as {Verb}-Az{Noun}, I'm okay to accept these conversions.

@isra-fel isra-fel assigned LucasYao93 and unassigned dingmeng-xue Jan 6, 2021
@LucasYao93 LucasYao93 requested a review from BethanyZhou January 6, 2021 07:12
BethanyZhou
BethanyZhou suggested changes Jan 8, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave one comment. Others LGTM

BethanyZhou
BethanyZhou previously approved these changes Jan 8, 2021
View reviewed changes
dingmeng-xue
dingmeng-xue reviewed Jan 11, 2021
View reviewed changes
@isra-fel
Copy link
Copy Markdown
Member

isra-fel commented Jan 11, 2021

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Jan 11, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@LucasYao93
Copy link
Copy Markdown
Contributor Author

LucasYao93 commented Jan 13, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Jan 13, 2021

Azure Pipelines successfully started running 3 pipeline(s).

BethanyZhou
BethanyZhou reviewed Jan 13, 2021
View reviewed changes
BethanyZhou
BethanyZhou suggested changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Leaved one comment.

@LucasYao93 LucasYao93 added this to the S182 (2021-02-09) milestone Jan 13, 2021
BethanyZhou
BethanyZhou previously approved these changes Jan 13, 2021
View reviewed changes
@BethanyZhou
Copy link
Copy Markdown
Contributor

BethanyZhou commented Jan 15, 2021

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Jan 15, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@dingmeng-xue dingmeng-xue merged commit 2ad4b83 into Azure:master Jan 18, 2021
@LucasYao93 LucasYao93 deleted the lucas/SmokeTest branch May 24, 2021 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dingmeng-xue dingmeng-xue Awaiting requested review from dingmeng-xue

1 more reviewer

@BethanyZhou BethanyZhou BethanyZhou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BethanyZhou BethanyZhou

@LucasYao93 LucasYao93

@dingmeng-xue dingmeng-xue

Labels

needs-review

Projects

None yet

Milestone

S182 (2021-02-09)

Development

Successfully merging this pull request may close these issues.

4 participants

@LucasYao93 @BethanyZhou @isra-fel @dingmeng-xue