Skip to content

Load assemblies from PreloadAssemblies for bumping version#13799

Merged
dingmeng-xue merged 1 commit intomasterfrom
dixue/bugfix
Dec 21, 2020
Merged

Load assemblies from PreloadAssemblies for bumping version#13799
dingmeng-xue merged 1 commit intomasterfrom
dixue/bugfix

Conversation

@dingmeng-xue
Copy link
Copy Markdown
Member

Description

During static anlaysis, it needs to load all required assemblies into AppDomain. Current logic only loads files from root folder of module and its dependencies. However some assemblies are moved to Az.Accounts/PreloadAssemblies. Below code loads assemblies from that folder if it cannot be found from default folders.

PR validation cannot find this issue because it uses PSM1 to load files when configuration is debug.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
      • {Please put the link here}
    • the markdown help files have been regenerated using the commands listed here

@dingmeng-xue dingmeng-xue added this to the S180 (2020-12-29) milestone Dec 21, 2020
@dingmeng-xue dingmeng-xue merged commit cfa3c8e into master Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants