New module for Security insights (Azure Sentinel) Resource Provider by dicolanl · Pull Request #13607 · Azure/azure-powershell

dicolanl · 2020-11-29T19:28:10Z

Description

New module for Security Insights (Azure Sentinel) RP.

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
  - {Please put the link here}
- the markdown help files have been regenerated using the commands listed here

This reverts commit 4dddc6c.

This reverts commit 7904f59.

Removed redundant "}"

…powershell into SecurityInsights

Fixed curly bracket

…powershell into SecurityInsights

msJinLei · 2020-12-01T03:56:40Z

@dicolanl
Please submit a design review here firstly https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues

dicolanl · 2020-12-01T15:43:18Z

@dicolanl
Please submit a design review here firstly https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues

Done. https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/788

wyunchi-ms · 2020-12-09T07:47:58Z

Please record the test case by following the help document here.
Please revert the changes in other modules such as Dns, Media and tools/PS-VSPrompt.lnk.
Please add your module into azure-powershell-modules

#13607 (comment)

dicolanl · 2020-12-09T17:05:18Z

@wyunchi-ms I have pushed a new commit with the changes requested.

new recordings
2.Reverted those files
added to the documentation

wyunchi-ms · 2020-12-10T07:23:40Z

Please follow the StaticAnalysis exception to modify the parameter names in your code except Alerts.

  "AssemblyFileName","ClassName","Target","Severity","ProblemId","Description","Remediation"
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.Incidents.NewIncidentsOwner","New-AzSentinelIncidentOwner","1","8100","New-AzSentinelIncidentOwner Does not support ShouldProcess but the cmdlet verb New indicates that it should.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.NewDataConnectors","New-AzSentinelDataConnector","1","8410","Parameter Alerts of cmdlet New-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.NewDataConnectors","New-AzSentinelDataConnector","1","8410","Parameter Logs of cmdlet New-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.NewDataConnectors","New-AzSentinelDataConnector","1","8410","Parameter DiscoveryLogs of cmdlet New-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.NewDataConnectors","New-AzSentinelDataConnector","1","8410","Parameter Indicators of cmdlet New-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.UpdateDataConnectors","Update-AzSentinelDataConnector","1","8410","Parameter Alerts of cmdlet Update-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.UpdateDataConnectors","Update-AzSentinelDataConnector","1","8410","Parameter Logs of cmdlet Update-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.UpdateDataConnectors","Update-AzSentinelDataConnector","1","8410","Parameter DiscoveryLogs of cmdlet Update-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.DataConnectors.UpdateDataConnectors","Update-AzSentinelDataConnector","1","8410","Parameter Indicators of cmdlet Update-AzSentinelDataConnector does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.Bookmarks.NewBookmarks","New-AzSentinelBookmark","1","8410","Parameter Notes of cmdlet New-AzSentinelBookmark does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.Bookmarks.UpdateBoomarks","Update-AzSentinelBookmark","1","8410","Parameter Notes of cmdlet Update-AzSentinelBookmark does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.AlertRules.NewAlertRules","New-AzSentinelAlertRule","1","8410","Parameter Tactics of cmdlet New-AzSentinelAlertRule does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
  "D:\a\1\s\artifacts\Debug\Az.SecurityInsights\Microsoft.Azure.PowerShell.Cmdlets.SecurityInsights.dll","Microsoft.Azure.Commands.SecurityInsights.Cmdlets.Actions.UpdateAlertRules","Update-AzSentinelAlertRule","1","8410","Parameter Tactics of cmdlet Update-AzSentinelAlertRule does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."

wyunchi-ms · 2020-12-10T08:14:55Z

Please revert the changes in other modules such as Dns, Media and tools/PS-VSPrompt.lnk.
Is AlertRuleId and BookmarkId these are random generated? It seems that these id are regenerated when we run test cases. So the test framework cannot find the right http record by using url. There are two ways to fix this
1. Is there any way you can pass a fixed id into cmdlet when create a new AlertRule or other new cmdlet?
2. Or you can implement a HTTPMockServer.Matcher here is an example.

dicolanl · 2020-12-10T21:50:44Z

@wyunchi-ms
I updated module per static analysis, except for *-AzSentinelDataConnector. Like Alerts, the other parameters should have exceptions for plural. Logs, DiscoveryLogs, Indicators. How do i add them to the exception list?

actually fixed those files this time
updated tests to use static guids.

wyunchi-ms · 2020-12-12T08:19:40Z

/azp run

azure-pipelines · 2020-12-12T08:20:03Z

Azure Pipelines successfully started running 3 pipeline(s).

wyunchi-ms · 2020-12-14T04:50:25Z

/azp run

azure-pipelines · 2020-12-14T04:50:47Z

Azure Pipelines successfully started running 3 pipeline(s).

dicolanl and others added 30 commits November 11, 2020 15:59

v1

58dbc1e

Actions, AlertRules

c44a0a0

Bookmarks... start incident comments

447c078

more updates

f6d49ac

Incident Comments

194ca1c

major updates

b1948c6

fixes

43f558d

more fixes

968f387

GetAlertRuleTemplates updates

d237671

Update Az.SecurityInsights.psd1

b02b40d

v1 tests

92b7f74

tests.....

4dddc6c

Revert "tests....."

7904f59

This reverts commit 4dddc6c.

Revert "Revert "tests.....""

4603d15

This reverts commit 7904f59.

test v2

1b6c52d

tests complete... starting bug fixes

845596f

bugs

36bdd56

Update NewBookmarks.cs

1080a0f

Removed redundant "}"

bugs

afd9268

Merge branch 'SecurityInsights' of https://github.com/dicolanl/azure-…

9b79dae

…powershell into SecurityInsights

Update NewBookmarks.cs

0df5e8c

Fixed curly bracket

updates

e00bd79

Merge branch 'SecurityInsights' of https://github.com/dicolanl/azure-…

329a183

…powershell into SecurityInsights

updates after testing

c1ab0d9

bugs....

031d4a7

fix input object

413ca82

Added tests for input objects

29638e0

Generate Help

6bb1001

added examples to help files based on build failure

1ea9744

add online link to help files

7c4c9a9

wyunchi-ms self-assigned this Dec 7, 2020

dicolanl added 2 commits December 8, 2020 04:14

Moved Set- Commands to Update-

1884e0d

bug fix to help docs

12e96ff

wyunchi-ms added needs-revision and removed Cmdlet Review Required ⚠️ labels Dec 9, 2020

Updates per feedback

78b7d8d

#13607 (comment)

dicolanl added 5 commits December 10, 2020 15:12

Update Dns.sln

527dbab

Update Media.sln

fc9ee31

Update Media.sln

9f670ea

Update Media.sln

8d2fe38

Fixes per comments

7df21d5

dicolanl added 2 commits December 10, 2020 22:21

remove dependacy on logic app module

7dc8dd8

Add exceptions for static analysis

0804cb3

wyunchi-ms added 3 commits December 12, 2020 16:22

Update SignatureIssues.csv

2e10fd7

Update SignatureIssues.csv

b4caa25

Update SignatureIssues.csv

1ee9fe4

wyunchi-ms approved these changes Dec 14, 2020

View reviewed changes

wyunchi-ms merged commit def340e into Azure:master Dec 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New module for Security insights (Azure Sentinel) Resource Provider#13607

New module for Security insights (Azure Sentinel) Resource Provider#13607
wyunchi-ms merged 44 commits intoAzure:masterfrom
dicolanl:SecurityInsights

dicolanl commented Nov 29, 2020

Uh oh!

msJinLei commented Dec 1, 2020

Uh oh!

dicolanl commented Dec 1, 2020

Uh oh!

wyunchi-ms commented Dec 9, 2020

Uh oh!

dicolanl commented Dec 9, 2020

Uh oh!

wyunchi-ms commented Dec 10, 2020

Uh oh!

wyunchi-ms commented Dec 10, 2020

Uh oh!

dicolanl commented Dec 10, 2020

Uh oh!

wyunchi-ms commented Dec 12, 2020

Uh oh!

azure-pipelines bot commented Dec 12, 2020

Uh oh!

wyunchi-ms commented Dec 14, 2020

Uh oh!

azure-pipelines bot commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dicolanl commented Nov 29, 2020

Description

Checklist

Uh oh!

msJinLei commented Dec 1, 2020

Uh oh!

dicolanl commented Dec 1, 2020

Uh oh!

wyunchi-ms commented Dec 9, 2020

Uh oh!

dicolanl commented Dec 9, 2020

Uh oh!

wyunchi-ms commented Dec 10, 2020

Uh oh!

wyunchi-ms commented Dec 10, 2020

Uh oh!

dicolanl commented Dec 10, 2020

Uh oh!

wyunchi-ms commented Dec 12, 2020

Uh oh!

azure-pipelines bot commented Dec 12, 2020

Uh oh!

wyunchi-ms commented Dec 14, 2020

Uh oh!

azure-pipelines bot commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants