Skip to content

[Pipeline] Require specified build from 'azure-powershell - sign' to download#13270

Merged
isra-fel merged 5 commits intomasterfrom
bez/smokeTestPipeline
Nov 6, 2020
Merged

[Pipeline] Require specified build from 'azure-powershell - sign' to download#13270
isra-fel merged 5 commits intomasterfrom
bez/smokeTestPipeline

Conversation

@BethanyZhou
Copy link
Copy Markdown
Contributor

@BethanyZhou BethanyZhou commented Oct 20, 2020 •
edited
Loading

Description

Before: Always consume the newest build artifacts of 'azure-powershell - sign'

Now: Get the build artifacts by pipeline id.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from 95b5a1f to e199fb7 Compare October 20, 2020 06:02
@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from b9fbc87 to 1713b02 Compare October 20, 2020 06:53
@msJinLei
Copy link
Copy Markdown
Contributor

msJinLei commented Oct 21, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Oct 21, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Copy Markdown
Member

isra-fel commented Oct 22, 2020

@BethanyZhou is this PR ready for review and shall I review it?

@BethanyZhou
Copy link
Copy Markdown
Contributor Author

BethanyZhou commented Oct 22, 2020

Yes, please help to review it.

@isra-fel isra-fel self-assigned this Oct 22, 2020
isra-fel
isra-fel reviewed Oct 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you trigger a test run?

@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from d96ac03 to 1713b02 Compare October 26, 2020 05:54
@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from 742ce3c to e0b1100 Compare October 26, 2020 08:48
@BethanyZhou
Copy link
Copy Markdown
Contributor Author

BethanyZhou commented Oct 28, 2020

/azp run azure-powershell - powershell-core

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Oct 28, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch 2 times, most recently from 0c3743e to b2644a1 Compare October 28, 2020 03:13
@BethanyZhou BethanyZhou force-pushed the bez/smokeTestPipeline branch from b2644a1 to a3eeacc Compare October 28, 2020 04:07
@BethanyZhou
Copy link
Copy Markdown
Contributor Author

BethanyZhou commented Nov 2, 2020

A running example about getting the latest artifacts is: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=593944&view=results
Get the specified artifacts: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=599860&view=results
Please take a look, thanks.

@BethanyZhou
Copy link
Copy Markdown
Contributor Author

BethanyZhou commented Nov 3, 2020

Retired subscription example: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=601857&view=results

isra-fel
isra-fel requested changes Nov 4, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my inline comments. Thanks

isra-fel
isra-fel approved these changes Nov 6, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@isra-fel isra-fel merged commit 5ad35b4 into master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isra-fel isra-fel isra-fel approved these changes

Assignees

@isra-fel isra-fel

@BethanyZhou BethanyZhou

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BethanyZhou @msJinLei @isra-fel @azuresdkci