Skip to content

Adding cmdlets for Azure Template Specs (Preview) with deployment support#13090

Merged
VeryEarly merged 60 commits intomasterfrom
TemplateSpecs
Oct 14, 2020
Merged

Adding cmdlets for Azure Template Specs (Preview) with deployment support#13090
VeryEarly merged 60 commits intomasterfrom
TemplateSpecs

Conversation

@stuartko
Copy link
Copy Markdown
Contributor

@stuartko stuartko commented Sep 28, 2020

Description

Adds new cmdlets for managing Template Specs:

  • Get-AzTemplateSpec
  • New-AzTemplateSpec
  • Set-AzTemplateSpec
  • Export-AzTemplateSpec
  • Remove-AzTemplateSpec

Also adds support for deploying Template Specs via the existing deployment cmdlets. Cmdlets underwent extensive design reviews and discussions, and have been used by customers for the past ~2 months under a private preview release.

The Template Specs service remains in private preview but will enter Public Preview in October.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • PR is "Adding Cmdlets for Template Specs (Private Preview) # 635"
    • the markdown help files have been regenerated using the commands listed here

stuartko and others added 30 commits May 13, 2020 17:34
@stuartko
Initial wrapped models for Template Specs (including versions/artifacts)
b36fea9
@stuartko
Template Specs: Initial cmdlets for Get/New/Remove. Does not include …
2f68b1d 
…artifact support
@stuartko
Initial check-in of the packaging engine for Template Specs
6396d15
@stuartko
Template Specs: Adding Export. Adding import from file (with packaging)
cd8b5d7
@stuartko
Removing debug console write line.
7a62b3b
@stuartko
Template Specs: Initial Get Cmdlet tests. TODO: Remove temp internal …
467a19a 
…package refs
@Xynoclafe
Added support for templateSpecs
7623683
@Xynoclafe
Merge branch 'TemplateSpecs' of https://github.com/Azure/azure-powers…
c142db5 
…hell into TemplateSpecs
@stuartko
Template Specs: Adding basic Template Spec creation cmdlet test
2a708b6
@stuartko
Template Specs: Adding test for removal cmdlet
1c5fa30
@stuartko
Remove relativePath rewrites from TemplateSpecPackagingEngine
935e8c9
@stuartko
Adding Set-AzTemplateSpec cmdlet + updating parameter set names
ca159f4
@stuartko
Template Specs: Adding cmdlet help. Adding Set-AzTemplateSpec to exports
1ea069d
@stuartko
Fixing help file typo
efcc11f
@stuartko
Template Specs: Changing -Id to -ResourceId as default id parameter (…
dc201c5 
…with -Id as alias)
@stuartko
Adding basic test for Set-AzTemplateSpec
a722fb5
@Xynoclafe
Merge branch 'TemplateSpecs' of https://github.com/Azure/azure-powers…
4d57b07 
…hell into TemplateSpecs
@Xynoclafe
Update SDK; Re-record tests; Test for templateSpec deployment
26114c4
@Xynoclafe
Fix test
5f70ee3
@Xynoclafe
Merge from master
e7248e3
@Xynoclafe
Dropping model suffix from templateSpec SDK
b57ce0a
@Xynoclafe
Use latest SDK
0697053
@Xynoclafe
Merge branch 'master' of https://github.com/Azure/azure-powershell in…
0bdaa99 
…to TemplateSpecs
@Xynoclafe
Rerecord test
bdef829
@Xynoclafe
Change SDK version
bf7c6c8
@Xynoclafe
rerecord tests for SDK version change
6e8a715
@Xynoclafe
Modify output formatting
ce80561
@Xynoclafe
Merge branch 'master' of https://github.com/Azure/azure-powershell in…
f314be9 
…to TemplateSpecs
@stuartko
Template Specs: Fixing null reference exception
08ea488
@stuartko
Template Specs: Adding Id to Version Model
10a3a11
@VeryEarly VeryEarly self-assigned this Sep 29, 2020
VeryEarly
VeryEarly requested changes Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@VeryEarly VeryEarly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add supportshould process to export cmdlet

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Sep 29, 2020

is there API version changes involved in this SDK upgrade? If so, please re-record test cases

@stuartko
Copy link
Copy Markdown
Contributor Author

stuartko commented Sep 30, 2020

please add supportshould process to export cmdlet

shouldprocess has now been added to all applicable cmdlets.

is there API version changes involved in this SDK upgrade? If so, please re-record test cases

Not outside of the newly introduced cmdlets/template specs client. We should be good here.

FYI: I see that some tests are failing, but they look to be completely unrelated to these changes. I presume these are failing across the latest master?

@stuartko
Copy link
Copy Markdown
Contributor Author

stuartko commented Oct 2, 2020

@VeryEarly : Are there any further actions needed before this is merged?

@stuartko stuartko requested a review from VeryEarly October 2, 2020 00:19
@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Oct 12, 2020

@VeryEarly : Are there any further actions needed before this is merged?

those failed test cases have referenced get-azresource which has API upgrade.

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

@stuartko
Copy link
Copy Markdown
Contributor Author

stuartko commented Oct 12, 2020

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

Will this block the merge until it is fixed? Who is responsible for following up? Do we need to do anything further from our side?

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Oct 12, 2020

This unnecessary reference was caused by bad test implementation, need help from peering team do the fix.

Will this block the merge until it is fixed? Who is responsible for following up? Do we need to do anything further from our side?

We have some work around if developer from peering team was not managed to fix this issue. Let's wait for their response first.
Meanwhile please resolve merge conflicts.

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Oct 13, 2020

Hi @stuartko ,

Please take latest changes from master branch, thanks.

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented Oct 13, 2020

/azp run azure-powershell - windows-powershell

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented Oct 13, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@VeryEarly VeryEarly merged commit 08ed3c6 into master Oct 14, 2020
@isra-fel isra-fel deleted the TemplateSpecs branch October 15, 2020 02:45
@isra-fel isra-fel mentioned this pull request Oct 15, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels

needs-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stuartko @VeryEarly @azuresdkci @Xynoclafe @shenglol