Remove ApiVersion Parameter and change Get-AzResourceGroupOperation implementation to use SDK#12642
Merged
msJinLei merged 19 commits intoAzure:Az.Resources-previewfrom Sep 3, 2020
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
Member
|
For public API changes to cmdlets, a cmdlet design review was approved for the changes in this repository Besides, removing a parameter is a breaking change. The nearest sprint open for breaking changes will be S177. We suggest:
|
Contributor
Author
Breaking change attributes have already been added and are present in the Master branch |
Member
Great
Ah yes, but still please submit a design review. Thanks |
filizt
reviewed
Aug 17, 2020
| /// [CmdletParameterBreakingChange("SubscriptionId", ChangeDescription = "Parameter is deprecated and is a no-op parameter. It will be retired in a future release")] | ||
| [Parameter(Mandatory = false, ValueFromPipeline = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The subscription to use.")] | ||
| [ValidateNotNullOrEmpty] | ||
| public Guid? SubscriptionId { get; set; } |
Contributor
There was a problem hiding this comment.
public Guid? SubscriptionId { get; set; } [](start = 8, length = 41)
Let's add a task on the board to remove this parameter later.
filizt
previously approved these changes
Aug 17, 2020
Contributor
filizt
left a comment
There was a problem hiding this comment.
Changes LGTM. We might need to look at the failing pipeline tasks.
Contributor
Author
|
Contributor
|
@Xynoclafe You need to suppress the breaking change warning in your PR to pass the static analysis. |
filizt
reviewed
Aug 19, 2020
| Default value: None | ||
| Accept pipeline input: False | ||
| Accept wildcard characters: True | ||
| Accept wildcard characters: False |
Contributor
There was a problem hiding this comment.
Not sure if these are related to your changes.
Contributor
Author
Working on it |
Contributor
Author
|
@msJinLei @isra-fel |
Contributor
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
We will check the errors since there are unexpected ones |
Contributor
Author
Any updates on this? |
Contributor
They are not false positives errors. When a parameter is removed from cmdlet, it is evaluated twice in static analysis. And so please check the cmdlets and parameter sets reported to see whether there is any change in the parameter set, including removed parameters (optional or mandatory), additional mandatory parameters. If yes, just suppress the error. Sorry for the trouble, we will improve the tools in the future. |
Contributor
Author
|
I think I've already regenerated the help files. But yes, I will verify the case with parameter sets and suppress them accordingly |
filizt
approved these changes
Sep 2, 2020
msJinLei
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added