[SQL MI]Add support for Service principal and guest users in Set-AzSqlInstanceActiveDirectoryAdministrator cmdlet by amolagar5 · Pull Request #12197 · Azure/azure-powershell

amolagar5 · 2020-06-17T13:16:41Z

Added support for Service principal and guest users in Set-AzSqlInstanceActiveDirectoryAdministrator cmdlet

Checklist

I have read the Submitting Changes section of CONTRIBUTING.md
The title of the PR is clear and informative
The appropriate ChangeLog.md file(s) has been updated:
- For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
- A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
The PR does not introduce breaking changes
If applicable, the changes made in the PR have proper test coverage
For public API changes to cmdlets:
- a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
- the markdown help files have been regenerated using the commands listed here

…re Active Directory admin.

…DirectoryAdministrator command. We will be adding a new API to enable this option.

…to amagarwa/dev/ApplicationAsAADAdmin

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

…nceActiveDirectoryAdministrator cmdlet

adxsdkps · 2020-06-17T13:16:43Z

Can one of the admins verify this patch?

VeryEarly · 2020-06-18T02:27:02Z

Updated changelog.md
please update ## Upcoming release session only
please add test cases to cover the new added logic

...ActiveDirectoryAdministrator/Services/AzureSqlInstanceActiveDirectoryAdministratorAdapter.cs

amolagar5 · 2020-06-18T15:17:25Z

Updated changelog.md
please update ## Upcoming release session only

please add test cases to cover the new added logic

Hey @VeryEarly ,
will fix changeLog
can you please help me with tests. Exiting tests fail with this error. Manually scenario is working. Do we need to set some environment variable for this.
System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /0c1edf5d-e5c5-4aca-ab69-ef194134f44b/servicePrincipals?$filter=appId%20eq%20'52b6d571-5ff9-4b8f-92de-4a5b1bcdbbef'&api-version=1.6'. Calling method Item().
Stack Trace:
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke()
at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\1\s\tools\ScenarioTest.ResourceManager\EnvironmentSetupHelper.cs:line 571
at Microsoft.Azure.Commands.ScenarioTest.SqlTests.SqlTestsBase.RunPowerShellTest(String[] scripts) in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\SqlTestsBase.cs:line 103
at Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ManagedInstanceActiveDirectoryAdministratorTests.TestManagedInstanceActiveDirectoryAdministrator() in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\ManagedInstanceActiveDirectoryAdministratorTests.cs:line 42
Standard Output Messages:

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

…hub.com/Azure/azure-powershell into amagarwa/dev/sqlmiaddSPGuestuserSupport

amolagar5 · 2020-06-18T15:35:20Z

Hey @VeryEarly ,
will fix changeLog
can you please help me with tests. Exiting tests fail with this error. Manually scenario is working. Do we need to set some environment variable for this.
System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /0c1edf5d-e5c5-4aca-ab69-ef194134f44b/servicePrincipals?$filter=appId%20eq%20'52b6d571-5ff9-4b8f-92de-4a5b1bcdbbef'&api-version=1.6'. Calling method Item().
Stack Trace:
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke()
at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\1\s\tools\ScenarioTest.ResourceManager\EnvironmentSetupHelper.cs:line 571
at Microsoft.Azure.Commands.ScenarioTest.SqlTests.SqlTestsBase.RunPowerShellTest(String[] scripts) in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\SqlTestsBase.cs:line 103
at Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ManagedInstanceActiveDirectoryAdministratorTests.TestManagedInstanceActiveDirectoryAdministrator() in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\ManagedInstance

@msJinLei @dingmeng-xue any idea about this. looks like tests scenarios not working with service principals.

VeryEarly · 2020-06-19T07:13:30Z

Hey @VeryEarly ,
will fix changeLog
can you please help me with tests. Exiting tests fail with this error. Manually scenario is working. Do we need to set some environment variable for this.
System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /0c1edf5d-e5c5-4aca-ab69-ef194134f44b/servicePrincipals?$filter=appId%20eq%20'52b6d571-5ff9-4b8f-92de-4a5b1bcdbbef'&api-version=1.6'. Calling method Item().
Stack Trace:
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke()
at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\1\s\tools\ScenarioTest.ResourceManager\EnvironmentSetupHelper.cs:line 571
at Microsoft.Azure.Commands.ScenarioTest.SqlTests.SqlTestsBase.RunPowerShellTest(String[] scripts) in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\SqlTestsBase.cs:line 103
at Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ManagedInstanceActiveDirectoryAdministratorTests.TestManagedInstanceActiveDirectoryAdministrator() in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\ManagedInstance

@msJinLei @dingmeng-xue any idea about this. looks like tests scenarios not working with service principals.

In your updated code, there are API calls to get serviceprincipal, so please re-record testcase: https://github.com/Azure/azure-powershell/blob/amagarwa/dev/sqlmiaddSPGuestuserSupport/src/Sql/Sql.Test/ScenarioTests/ManagedInstanceActiveDirectoryAdministratorTests.ps1

amolagar5 · 2020-06-19T17:56:12Z

Hey @VeryEarly ,
will fix changeLog
can you please help me with tests. Exiting tests fail with this error. Manually scenario is working. Do we need to set some environment variable for this.
System.Management.Automation.ActionPreferenceStopException : The running command stopped because the preference variable "ErrorActionPreference" or common parameter is set to Stop: Unable to find a matching HTTP request for URL 'GET /0c1edf5d-e5c5-4aca-ab69-ef194134f44b/servicePrincipals?$filter=appId%20eq%20'52b6d571-5ff9-4b8f-92de-4a5b1bcdbbef'&api-version=1.6'. Calling method Item().
Stack Trace:
at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection1 input, PSDataCollection1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.CoreInvoke[TOutput](IEnumerable input, PSDataCollection`1 output, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke(IEnumerable input, PSInvocationSettings settings)
at System.Management.Automation.PowerShell.Invoke()
at Microsoft.WindowsAzure.Commands.ScenarioTest.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\1\s\tools\ScenarioTest.ResourceManager\EnvironmentSetupHelper.cs:line 571
at Microsoft.Azure.Commands.ScenarioTest.SqlTests.SqlTestsBase.RunPowerShellTest(String[] scripts) in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\SqlTestsBase.cs:line 103
at Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ManagedInstanceActiveDirectoryAdministratorTests.TestManagedInstanceActiveDirectoryAdministrator() in D:\a\1\s\src\Sql\Sql.Test\ScenarioTests\ManagedInstance

@msJinLei @dingmeng-xue any idea about this. looks like tests scenarios not working with service principals.

In your updated code, there are API calls to get serviceprincipal, so please re-record testcase: https://github.com/Azure/azure-powershell/blob/amagarwa/dev/sqlmiaddSPGuestuserSupport/src/Sql/Sql.Test/ScenarioTests/ManagedInstanceActiveDirectoryAdministratorTests.ps1

I see. that is the difficult part, last time I tried for 3 days and could not get it to work. Last dev has lef the team. :(, let me check if we want to re-record or just disable the test until we has a resource to fix test.

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

After trying multiple times to re-record it, I had no luck.

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

amolagar5 · 2020-06-22T06:00:07Z

Updated changelog.md
please update ## Upcoming release session only

please add test cases to cover the new added logic

@VeryEarly I have marked the test as skip. I debugged more and looks like its the token that 's going with graph call, its wrong and using https://management.core.windows.net/ and not https://graph.windows.net/, looks like in debugging all places I added my token are called fine. so puzzling. When calling ActiveDirectoryClient.FilterGroups(filter).Where(gr => string.Equals(gr.DisplayName, displayName, StringComparison.OrdinalIgnoreCase)); in MockScenario, it picks up wrong token. Wondering if problem is in ActiveDirectoryClient itself not supporting mock tests.

If know how mock tests with AAD will work, I can schedule a meeting and show you what I am doing to get it working and understand what else can I do to make it work.

VeryEarly · 2020-06-24T02:36:57Z

/azp run

azure-pipelines · 2020-06-24T02:37:16Z

Azure Pipelines successfully started running 3 pipeline(s).

amolagar5 added 9 commits May 15, 2020 16:03

Allow Azure Active Directory applications to be set as SQL Server Azu…

b03dcf1

…re Active Directory admin.

Remove IsAzureADOnlyAuthenticaion option from SetAzureSqlServerActive…

57d7bee

…DirectoryAdministrator command. We will be adding a new API to enable this option.

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

a52ae20

…to amagarwa/dev/ApplicationAsAADAdmin

Update ChangeLog.md

e843064

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

f334ef2

…to amagarwa/dev/ApplicationAsAADAdmin

Add Static analysis exception to exceptions file.

8257a8e

add support for service principal for set aad admin.

b820d2a

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

ed2f11c

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

Added support for Service principal and guest users in Set-AzSqlInsta…

136548e

…nceActiveDirectoryAdministrator cmdlet

amolagar5 requested a review from msJinLei June 17, 2020 13:20

VeryEarly self-assigned this Jun 18, 2020

VeryEarly added 3 commits June 18, 2020 10:23

Update ChangeLog.md

0c9bf4e

Update ChangeLog.md

db43cc4

Update ChangeLog.md

b052a61

dmitarredz reviewed Jun 18, 2020

View reviewed changes

...ActiveDirectoryAdministrator/Services/AzureSqlInstanceActiveDirectoryAdministratorAdapter.cs Outdated Show resolved Hide resolved

dmitarredz previously approved these changes Jun 18, 2020

View reviewed changes

amolagar5 added 3 commits June 18, 2020 08:18

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

da11851

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

Fix typo in variable name

5ffe0f0

Merge branch 'amagarwa/dev/sqlmiaddSPGuestuserSupport' of https://git…

6298605

…hub.com/Azure/azure-powershell into amagarwa/dev/sqlmiaddSPGuestuserSupport

amolagar5 dismissed dmitarredz’s stale review via 6298605 June 18, 2020 15:24

Merge with released file.

2bf4cd8

azuresdkci added the needs-review label Jun 19, 2020

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

9e5dacd

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

VeryEarly removed the needs-review label Jun 22, 2020

VeryEarly assigned amolagar5 Jun 22, 2020

amolagar5 added 2 commits June 21, 2020 22:48

Marking MI AAD Admin test as needing re-recording.

e612916

After trying multiple times to re-record it, I had no luck.

Merge branch 'master' of https://github.com/Azure/azure-powershell in…

1249a37

…to amagarwa/dev/sqlmiaddSPGuestuserSupport

VeryEarly approved these changes Jun 24, 2020

View reviewed changes

VeryEarly merged commit a77b31e into master Jun 24, 2020

wyunchi-ms deleted the amagarwa/dev/sqlmiaddSPGuestuserSupport branch January 10, 2024 02:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SQL MI]Add support for Service principal and guest users in Set-AzSqlInstanceActiveDirectoryAdministrator cmdlet#12197

[SQL MI]Add support for Service principal and guest users in Set-AzSqlInstanceActiveDirectoryAdministrator cmdlet#12197
VeryEarly merged 19 commits intomasterfrom
amagarwa/dev/sqlmiaddSPGuestuserSupport

amolagar5 commented Jun 17, 2020 •

edited

Loading

Uh oh!

adxsdkps commented Jun 17, 2020

Uh oh!

VeryEarly commented Jun 18, 2020 •

edited

Loading

Uh oh!

Uh oh!

amolagar5 commented Jun 18, 2020

Uh oh!

amolagar5 commented Jun 18, 2020

Uh oh!

VeryEarly commented Jun 19, 2020

Uh oh!

amolagar5 commented Jun 19, 2020

Uh oh!

amolagar5 commented Jun 22, 2020 •

edited

Loading

Uh oh!

VeryEarly commented Jun 24, 2020

Uh oh!

azure-pipelines bot commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

amolagar5 commented Jun 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

adxsdkps commented Jun 17, 2020

Uh oh!

VeryEarly commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

amolagar5 commented Jun 18, 2020

Uh oh!

amolagar5 commented Jun 18, 2020

Uh oh!

VeryEarly commented Jun 19, 2020

Uh oh!

amolagar5 commented Jun 19, 2020

Uh oh!

amolagar5 commented Jun 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VeryEarly commented Jun 24, 2020

Uh oh!

azure-pipelines bot commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

amolagar5 commented Jun 17, 2020 •

edited

Loading

VeryEarly commented Jun 18, 2020 •

edited

Loading

amolagar5 commented Jun 22, 2020 •

edited

Loading