[ExpressRoute][GlobalReach]Remove-AzExpressRouteCircuitConnectionConfig to have another param AddressPrefixType to remove individual address family configs#12020
Merged
VeryEarly merged 2 commits intoAzure:masterfrom May 29, 2020
amwate:ERGRIPv6_RemoveCCC_AddressType
Merged
[ExpressRoute][GlobalReach]Remove-AzExpressRouteCircuitConnectionConfig to have another param AddressPrefixType to remove individual address family configs#12020VeryEarly merged 2 commits intoAzure:masterfrom amwate:ERGRIPv6_RemoveCCC_AddressType
VeryEarly merged 2 commits intoAzure:masterfrom
amwate:ERGRIPv6_RemoveCCC_AddressType
Conversation
…dressPrefixType to remove the IPv4 or IPv6 configuration.
Collaborator
|
Can one of the admins verify this patch? |
Member
|
@amwate -- I'm no longer a member of the Azure PowerShell team, so I have removed myself as a reviewer for this PR. |
VeryEarly
approved these changes
May 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dressPrefixType to remove the IPv4 or IPv6 configuration.
Description
This PR addresses addition of another parameter AddressPrefixType to the existing Remove-AzExpressRouteCircuitConnectionConfig cmdlet.
The cmdlet to have another parameter for partial removal of the config based on the address family.
If none is specified (as in legacy scenarios), the entire configuration would be removed.
This is to keep it consistent with the earlier behavior.
The design review for the same was addressed as part of
https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/601.
This is also an extension of the earlier PR : #11501, where we had introduced the Set-AzExpressRouteCircuitConnectionConfig for the resource.
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added