Changes to PS Deployment Script cmdlets#11951
Merged
VeryEarly merged 22 commits intoAzure:masterfrom May 25, 2020
Merged
Conversation
…to xynoclafe/PSDeploymentScript
…to xynoclafe/PSDeploymentScript
…to xynoclafe/PSDeploymentScript
… Save-AzDeploymentScriptLog cmdlet
…criptObject; Show Output property in cmdlet output
…Remove Deployment Script on target
…to xynoclafe/PSDeploymentScriptMisc
…to xynoclafe/PSDeploymentScriptMisc
Collaborator
|
Can one of the admins verify this patch? |
filizt
reviewed
May 20, 2020
src/Resources/ResourceManager/Implementation/DeploymentScripts/SaveAzDeploymentScriptLog.cs
Outdated
Show resolved
Hide resolved
filizt
reviewed
May 20, 2020
| string rowFormat = "{0, -" + maxNameLength + "} {1, -" + maxTypeLength + "}\r\n"; | ||
| output.AppendLine(); | ||
| output.AppendFormat(rowFormat, "Key", "Value"); | ||
| output.AppendFormat(rowFormat, GeneralUtilities.GenerateSeparator(maxNameLength, "="), GeneralUtilities.GenerateSeparator(maxNameLength, "=")); |
Contributor
There was a problem hiding this comment.
GeneralUtilities.GenerateSeparator(maxNameLength, "=") [](start = 106, length = 55)
A bit confused with the use of maxTypeLength. You don't seem to use it in the AppendFormat, do we need it then? #Resolved
Contributor
Author
There was a problem hiding this comment.
Ah yes, I think I can get rid of that variable. I was using it earlier to determine the length of the separating line at the top. It's redundant now.
filizt
previously approved these changes
May 22, 2020
VeryEarly
approved these changes
May 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added