Skip to content

Add DesktopVirtualization#11943

Merged
dolauli merged 5 commits intoAzure:masterfrom
dingmeng-xue:autogen
May 25, 2020
Merged

Add DesktopVirtualization#11943
dolauli merged 5 commits intoAzure:masterfrom
dingmeng-xue:autogen

Conversation

@dingmeng-xue
Copy link
Copy Markdown
Member

@dingmeng-xue dingmeng-xue commented May 19, 2020

Description

Add DesktopVirtualization

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@adxsdkps
Copy link
Copy Markdown
Collaborator

adxsdkps commented May 19, 2020

Can one of the admins verify this patch?

@dingmeng-xue dingmeng-xue added this to the S170 (2020-06-02) milestone May 19, 2020
@dingmeng-xue dingmeng-xue requested a review from dolauli May 19, 2020 09:04
@VeryEarly VeryEarly self-assigned this May 20, 2020
@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented May 20, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented May 20, 2020

@dingmeng-xue The test failed is because there is no internal cmdlets for this module. So we probably need a check in https://github.com/Azure/azure-powershell/blob/master/src/Az.autorest.props to check whether the file exists.
<Copy SourceFiles="internal\ProxyCmdletDefinitions.ps1" DestinationFolder="$(RepoArtifacts)$(Configuration)\Az.$(PsModuleName)\internal" />

@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented May 21, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 21, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli
Copy link
Copy Markdown
Contributor

dolauli commented May 21, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 21, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@dingmeng-xue dingmeng-xue assigned dolauli and unassigned VeryEarly May 25, 2020
dolauli
dolauli approved these changes May 25, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dolauli dolauli merged commit fd2eb43 into Azure:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dolauli dolauli dolauli approved these changes

Assignees

@dolauli dolauli

Labels

None yet

Projects

None yet

Milestone

S170 (2020-06-02)

Development

Successfully merging this pull request may close these issues.

4 participants

@dingmeng-xue @adxsdkps @dolauli @VeryEarly