Skip to content

[DeviceProvisioningServices] Manage enrollment groups in an Azure IoT Hub Device Provisioning Service.#11926

Merged
VeryEarly merged 4 commits intoAzure:masterfrom
anusapan:dps-enroll-grp
May 20, 2020
Merged

[DeviceProvisioningServices] Manage enrollment groups in an Azure IoT Hub Device Provisioning Service.#11926
VeryEarly merged 4 commits intoAzure:masterfrom
anusapan:dps-enroll-grp

Conversation

@anusapan
Copy link
Copy Markdown
Contributor

@anusapan anusapan commented May 18, 2020

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@anusapan
Copy link
Copy Markdown
Contributor Author

anusapan commented May 18, 2020

Cmdlet Design : https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/595

@anusapan
Copy link
Copy Markdown
Contributor Author

anusapan commented May 19, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 19, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly self-assigned this May 19, 2020
@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented May 19, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 19, 2020

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly
VeryEarly reviewed May 19, 2020
View reviewed changes
...ervices/DeviceProvisioningServices/help/Get-AzIoTDeviceProvisioningServiceEnrollmentGroup.md Outdated
Copy link
Copy Markdown
Collaborator

@VeryEarly VeryEarly May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like duplicate output type

Copy link
Copy Markdown
Contributor Author

@anusapan anusapan May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. It should be an array type.

VeryEarly
VeryEarly previously approved these changes May 19, 2020
View reviewed changes
@VeryEarly VeryEarly dismissed their stale review May 19, 2020 06:11

needs revision

@anusapan
Copy link
Copy Markdown
Contributor Author

anusapan commented May 20, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown
Contributor

azure-pipelines bot commented May 20, 2020

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly VeryEarly merged commit e64f417 into Azure:master May 20, 2020
@anusapan anusapan deleted the dps-enroll-grp branch May 20, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anusapan @VeryEarly