Skip to content

Support PrivateEndpoint and PublicNetworkAccess control#11919

Merged
VeryEarly merged 1 commit intomasterfrom
unknown repository
May 19, 2020
Merged

Support PrivateEndpoint and PublicNetworkAccess control#11919
VeryEarly merged 1 commit intomasterfrom
unknown repository

Conversation

@yangyuan
Copy link
Copy Markdown
Member

@yangyuan yangyuan commented May 17, 2020 •
edited
Loading

Description

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@VeryEarly
Copy link
Copy Markdown
Collaborator

VeryEarly commented May 18, 2020

Hi @yangyuan ,

Since there are properties added in "PSCognitiveServicesAcount", do you think new corresponding parameters need to be added to
New-AzCognitiveServicesAccount
and
Set-AzCognitiveServicesAccount

@VeryEarly VeryEarly self-assigned this May 18, 2020
@yangyuan
Copy link
Copy Markdown
Member Author

yangyuan commented May 18, 2020

Hi @VeryEarly.
No need to update New/Set-AzCognitiveServicesAccount.

PrivateEndpoint fields are readonly, they are managed by Network PowerShells.
PublicNetworkAccess is right now just for reference only (right now the value is always "Enabled"). We will update powershell after we allowing modifying this field.

@VeryEarly VeryEarly merged commit 8996ca5 into Azure:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeryEarly VeryEarly VeryEarly approved these changes

Assignees

@VeryEarly VeryEarly

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yangyuan @VeryEarly