Skip to content

Added Tail parameter to Get-AzDeploymentScriptLog and Save-AzDeploymentScriptLog cmdlets#11826

Merged
wyunchi-ms merged 10 commits intoAzure:masterfrom
Xynoclafe:xynoclafe/PSDeploymentScript
May 18, 2020
Merged

Added Tail parameter to Get-AzDeploymentScriptLog and Save-AzDeploymentScriptLog cmdlets#11826
wyunchi-ms merged 10 commits intoAzure:masterfrom
Xynoclafe:xynoclafe/PSDeploymentScript

Conversation

@Xynoclafe
Copy link
Copy Markdown
Contributor

@Xynoclafe Xynoclafe commented May 7, 2020 •
edited
Loading

Description

  • Added Tail parameter to Get-AzDeploymentScriptLog and Save-AzDeploymentScriptLog cmdlets
  • Added, updated and re-recorded testcases for these cmdlets
  • Updated help for these cmdlets

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@Xynoclafe Xynoclafe requested review from filizt and shenglol May 7, 2020 01:08
@adxsdkps
Copy link
Copy Markdown
Collaborator

adxsdkps commented May 7, 2020

Can one of the admins verify this patch?

filizt
filizt reviewed May 7, 2020
View reviewed changes
@wyunchi-ms
Copy link
Copy Markdown
Contributor

wyunchi-ms commented May 9, 2020 •
edited
Loading

Please resolve the conflicts after you fix these conversations. @Xynoclafe

filizt
filizt reviewed May 13, 2020
View reviewed changes
filizt
filizt reviewed May 13, 2020
View reviewed changes
src/Resources/Resources.Test/ScenarioTests/DeploymentScriptsTests.ps1 Outdated
Assert-NotNull $getLogByNameAndResourceGroupWithTail
Assert-NotNull $deploymentScriptName $getLogByNameAndResourceGroupWithTail.Log
Assert-AreEqual $deploymentScriptName $getLogByNameAndResourceGroupWithTail.DeploymentScriptName
Assert-AreEqual ($getLogByNameAndResourceGroupWithTail.Log -split '\n').count $Tail
Copy link
Copy Markdown
Contributor

@filizt filizt May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

filizt
filizt reviewed May 13, 2020
View reviewed changes
@filizt
Copy link
Copy Markdown
Contributor

filizt commented May 13, 2020

Could you also give a descriptive title to the PR and mark the items in the checklist? @Xynoclafe

@Xynoclafe Xynoclafe changed the title Xynoclafe/ps deployment script Added Tail parameter to Get-AzDeploymentScriptLog and Save-AzDeploymentScriptLog cmdlets May 13, 2020
@filizt filizt self-requested a review May 14, 2020 03:28
filizt
filizt approved these changes May 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@filizt filizt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wyunchi-ms wyunchi-ms merged commit c09b981 into Azure:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyunchi-ms wyunchi-ms wyunchi-ms approved these changes

+2 more reviewers

@shenglol shenglol shenglol approved these changes

@filizt filizt filizt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shenglol shenglol

@wyunchi-ms wyunchi-ms

Labels

needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Xynoclafe @adxsdkps @wyunchi-ms @filizt @shenglol