Fixed property type in PSConnectionMonitorSuccessThreshold object#11630
Closed
irrogozh wants to merge 5 commits intoAzure:network-aprilfrom
irrogozh:network-april
Closed
Fixed property type in PSConnectionMonitorSuccessThreshold object#11630irrogozh wants to merge 5 commits intoAzure:network-aprilfrom irrogozh:network-april
irrogozh wants to merge 5 commits intoAzure:network-aprilfrom
irrogozh:network-april
Conversation
Contributor
|
Hi @irrogozh , because the api-version from SDK is changed. Please rerecord the test cases. |
Member
Author
|
@wyunchi-ms , I talked to Anton Evseev. they are going to rerecord all networking tests once NRP release/142 is deployed everywhere. He suggested you to approve this PR (is it's possible) and leave it open. Then, after NRP changes deployed, Anton will re-record all tests, merge new recordings and rebase my PR. |
…oundTripTimeMs properties
…hell into network-april
Contributor
|
These changes were merged as part of #11769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added