Update to R5 RP 2019-07-01 API (#27)#10294
Conversation
|
Could do with some info on the failure https://dev.azure.com/azure-sdk/public/_build/results?buildId=144087&view=logs&jobId=e1b7b984-9f58-529f-7c5a-f15f8e35cfa6 please. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
properties "Nfsv4" and "CreationData" were renamed and were treated as breaking changes by system, suppress following error messages https://dev.azure.com/azure-sdk/public/_build/results?buildId=161091&view=artifacts Also you can check https://github.com/Azure/azure-powershell/blob/master/documentation/Debugging-StaticAnalysis-Errors.md for detail. |
ok, I have updated that file and the pipeline now passes. |
There was a problem hiding this comment.
how is this line different?
There was a problem hiding this comment.
Hmmm, really can't say. I don't see any difference and have not made any change to it.
There was a problem hiding this comment.
Check if there are any white spaces, could be caused by your text editor.
Also simply fix the merge conflict, let me know if you have any update.
I'll try to merge it for you as soon as I can.
There was a problem hiding this comment.
I suspect it was caused by the editor but there is no whitespace difference.
Concerning the merge conflicts, because this is test record files and there are too many diffs to fix in github, I know of no other way than cloning from azure, force pushing to my fork, reapplying all the changes and then rerunning all the tests. It also means the PR is closed and a new one must be opened. This is time consuming and happens a lot while things are in review. Is there a shorter way? Thanks.
There was a problem hiding this comment.
Try rebasing: https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md#rebasing
No need to close this or create a new PR, and no need to run all the tests by the way -- only the four tests that have conflicts need to be re-ran.
There was a problem hiding this comment.
I didn't have luck with rebasing but anyway the closure of the PR is not something I manually do but seems to occur with the force push. I will try again next time but for now this PR has closed and I will link another shortly.
Regarding the diff mentioned above, I've now seen that this is because the original file contains '<EF><BB><BF>' which was stripped out.
|
PR replaced by #10445 |
Description
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added