fix: update typing inspect get_origin check#1691
Merged
hallvictoria merged 14 commits intodevfrom Oct 29, 2025
Merged
Conversation
gavin-aguiar
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, this was the check in
get_function_return_type:If
typing_inspect.get_origin(return_anno)returnedNone, there would be an error thrown sayingAttributeError: 'NoneType' object has no attribute '__name__'.This change introduces a new check to ensure that
typing_inspect.get_origin(return_anno)is notNonebefore checking the__name__property.Change is already present in V1 & V2 runtimes.
Fixes #1688
PR information
Quality of Code and Contribution Guidelines