Skip to content

fix: prevent duplicate service target providers#8901

Merged
huimiu merged 5 commits into
mainfrom
hui/fix-duplicate-service-targets
Jul 1, 2026
Merged

fix: prevent duplicate service target providers#8901
huimiu merged 5 commits into
mainfrom
hui/fix-duplicate-service-targets

Conversation

@huimiu

@huimiu huimiu commented Jul 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove service-target provider claims from azure.ai.agents for hosts owned by the split Foundry extensions.

Fixes #8902

Validation

  • Verified no duplicate service-target providers in extension manifests.

@huimiu huimiu marked this pull request as ready for review July 1, 2026 02:33
Copilot AI review requested due to automatic review settings July 1, 2026 02:33
@github-actions github-actions Bot added the ext-agents azure.ai.agents extension label Jul 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens extension registry correctness by removing outdated service-target provider declarations from azure.ai.agents and adding validation to prevent duplicate service-target providers across the latest versions of extensions.

Changes:

  • Removed azure.ai.project, azure.ai.connection, and azure.ai.toolbox service-target provider entries from azure.ai.agents to avoid conflicts with split Foundry extensions.
  • Added registry-level validation to detect duplicate service-target providers across latest extension versions (case-insensitive), including duplicates within a single extension’s latest version.
  • Added unit tests covering both cross-extension and within-extension duplicate provider scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
cli/azd/pkg/extensions/validate_registry.go Adds a registry validation pass to reject duplicate latest-version service-target providers.
cli/azd/pkg/extensions/validate_registry_test.go Adds test coverage for duplicate provider detection across extensions and within one latest version.
cli/azd/extensions/azure.ai.agents/extension.yaml Removes service-target provider claims that belong to other split Foundry extensions.

Comment thread cli/azd/pkg/extensions/validate_registry.go Outdated
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

📋 Prioritization Note

Thanks for the contribution! The linked issue isn't in the current milestone yet.
Thank you for logging this issue; our team is reviewing it. If you need urgent prioritization, tag @RickWinter and @kristenwomack to let us know.

@huimiu huimiu requested a review from danieljurek as a code owner July 1, 2026 03:03
@huimiu

huimiu commented Jul 1, 2026

Copy link
Copy Markdown
Member Author

/check-enforcer override

@huimiu huimiu merged commit ab3fc23 into main Jul 1, 2026
22 of 26 checks passed
@huimiu huimiu deleted the hui/fix-duplicate-service-targets branch July 1, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-agents azure.ai.agents extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Duplicate service-target provider declarations block extension registry release

4 participants