Fix placeholder warning to reference azure.yaml instead of agent.yaml#8867
Conversation
…#8855) The unresolved placeholder warning and nextstep suggestions still referenced agent.yaml, but agent definitions now live inline in azure.yaml. Update all user-facing strings and related comments. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
There was a problem hiding this comment.
Pull request overview
This PR updates the azure.ai.agents extension’s unresolved-placeholder warning and related “Next:” guidance so users are directed to edit azure.yaml (where agent definitions now live) rather than the obsolete agent.yaml, aligning output with the current project shape and fixing #8855.
Changes:
- Updated the unresolved placeholder warning text to reference
azure.yaml. - Updated nextstep placeholder “edit …” suggestions to reference
azure.yaml. - Updated related comments and test expectations to match the new wording.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/parameters.go | Updates the unresolved-placeholder warning and associated comments to reference azure.yaml. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/state.go | Adjusts placeholder-related commentary to align with azure.yaml guidance. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/resolver.go | Updates placeholder fix-up suggestion strings to reference azure.yaml. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/resolver_test.go | Updates assertions expecting the placeholder fix-up suggestion text. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/nextstep/format_test.go | Updates formatting test fixtures/expected output for the azure.yaml placeholder suggestion text. |
There was a problem hiding this comment.
resolver.go:242 still has a user-facing description shown in the "Next:" suggestions:
Description: "referenced by agent.yaml but not set in azd env",This is the description for azd env set suggestions when manual vars are missing. If the intent is to update all user-visible references to agent.yaml, this one should also say azure.yaml (or whatever phrasing fits the new model).
…d state comments - resolver.go:242 description string now says azure.yaml - state.go comment block updated (lines 533, 537) - resolver_test.go assertion updated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
left a comment
There was a problem hiding this comment.
The new commit addresses my prior feedback: resolver.go:242 now correctly says "referenced by azure.yaml". Tests and comments in state.go are updated too.
One remaining inconsistency in format_test.go: the test fixture at line 211 and expected output at line 227 still reference "agent.yaml" while other strings in the same test case were updated to "azure.yaml".
huimiu
left a comment
There was a problem hiding this comment.
Looks good overall -- one stale cross-reference in a file outside the diff worth catching.
cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/placeholders.go line 42: the comment reads "concrete 'edit agent.yaml' hint" but after this PR the nextstep guidance emits edit azure.yaml: replace ... instead. The comment explicitly says the two call sites must agree; updating it to 'edit azure.yaml' keeps that true.
(azd-code-reviewer)
- format_test.go lines 211/227: description now says azure.yaml - placeholders.go line 42: comment cross-reference updated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
left a comment
There was a problem hiding this comment.
My earlier comments are addressed - format_test.go and placeholders.go now correctly reference azure.yaml.
One remaining stale comment in format.go (not in this diff): the highlightCommand doc comment still says "edit agent.yaml: ..." instructions (around line 195). The matching comment in format_test.go line 428 was updated to "edit azure.yaml: ..." but the source file wasn't. Trivial fix if you want to keep comments consistent.
The unresolved placeholder warning and nextstep suggestions still referenced
agent.yaml, but agent definitions now live inline inazure.yaml. Users saw:This updates all user-facing strings (the warning message and the nextstep "edit ..." suggestions) to say
azure.yaml, along with related code comments and test assertions.Files changed:
parameters.go-- warningfmt.Printfand function doc commentsnextstep/resolver.go-- suggestion command/description strings and commentsnextstep/state.go-- comment describing the suggestion textnextstep/resolver_test.goandformat_test.go-- expected assertion stringsFixes: #8855